Move HelpSearch to Search sub-module [#3581109] | Drupal.org

Move HelpSearch to Search sub-module [#3581109] | Drupal.org
Skip to search
Can we use first and third party cookies and web beacons to
understand our audience, and to tailor promotions you see
Move HelpSearch to Search sub-module
Needs work
Project:
Drupal core
Version:
main
Component:
search.module
Priority:
Normal
Category:
Task
Assigned:
smustgrave
Reporter:
quietone
Created:
24 Mar 2026 at 07:19 UTC
Updated:
24 Apr 2026 at 13:02 UTC
Jump to comment:
Most recent
Most recent file
Problem/Motivation
The Help module has a Search plugin.
Steps to reproduce
Proposed resolution
Move HelpSearch to Search sub-module
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Comment
File
Size
Author
#18
3581109-nr-bot_qmwtydqp.txt
98 bytes
needs-review-queue-bot
#16
3581109-nr-bot_0qwx6b3y.txt
91 bytes
needs-review-queue-bot
#10
3581109-nr-bot_7axr8dkn.txt
91 bytes
needs-review-queue-bot
Issue fork
drupal-3581109
Show commands
Start within a Git clone of the project using the
version control instructions
Add & fetch this issue fork’s repository
Or,
if you do not have
SSH keys set up on git.drupalcode.org
Add & fetch this issue fork’s repository
1 hidden branch
3581109-move-helpsearch-to
plain diff
MR
!15184
Check out this branch for the first time
Check out existing branch, if you already have it locally
About issue forks
Comments
Comment
#1
24 March 2026 at 07:19
quietone
created an issue. See
original summary
or
to post comments
Comment
#2
24 March 2026 at 07:40
quietone
opened
merge request !15184
or
to post comments
Comment
#3
smustgrave
commented
28 March 2026 at 01:15
Assigned:
Unassigned
smustgrave
Going to give it a shot this weekend
or
to post comments
Comment
#4
smustgrave
commented
28 March 2026 at 04:45
Status:
Active
» Needs review
or
to post comments
Comment
#5
quietone
commented
28 March 2026 at 09:19
Status:
Needs review
» Needs work
or
to post comments
Comment
#6
smustgrave
commented
28 March 2026 at 16:16
Status:
Needs work
» Needs review
Addressed the feedback.
or
to post comments
Comment
#7
dcam
commented
1 April 2026 at 04:16
Status:
Needs review
» Needs work
I have concerns about one of the moved test functions. But I also left several other comments. Setting to Needs Work because of the test.
or
to post comments
Comment
#8
smustgrave
commented
1 April 2026 at 15:06
Status:
Needs work
» Needs review
Thoughts?
or
to post comments
Comment
#9
dcam
commented
1 April 2026 at 17:56
Status:
Needs review
» Reviewed & tested by the community
Thank you for considering my feedback.
This looks good. Feedback was addressed. I believe the only open comments are self-review notes. Thank you for adding those. They helped during the review.
or
to post comments
Comment
#10
needs-review-queue-bot
commented
12 April 2026 at 16:26
Status:
Reviewed & tested by the community
» Needs work
Status
File
Size
new
3581109-nr-bot_7axr8dkn.txt
91 bytes
The
Needs Review Queue Bot
tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the
Drupal Contributor Guide
to find step-by-step guides for working with issues.
or
to post comments
Comment
#11
quietone
commented
13 April 2026 at 06:32
Status:
Needs work
» Needs review
or
to post comments
Comment
#12
dcam
commented
13 April 2026 at 12:31
Status:
Needs review
» Reviewed & tested by the community
Updates were necessary due to
#3569127: Add new 11.3.x database dump fixtures, without modules deprecated for removal in 12.x
. They look good to me. Back to RTBC.
or
to post comments
Comment
#13
godotislate
he/him
commented
16 April 2026 at 13:53
Status:
Reviewed & tested by the community
» Needs work
NW for merge conflict.
or
to post comments
Comment
#14
quietone
commented
16 April 2026 at 22:44
Status:
Needs work
» Needs review
Rebase with conflicts in UpdatePathTestBaseFilledTest.php and UpdatePathTestBaseTest.php. And then the baseline needed to be regenerated.
or
to post comments
Comment
#15
dcam
commented
17 April 2026 at 00:34
Status:
Needs review
» Reviewed & tested by the community
Makes sense because the update fixtures were updated in the last week or so. I checked the most recent changes. They seem appropriate to me. Tests are green. Back to RTBC.
or
to post comments
Comment
#16
needs-review-queue-bot
commented
21 April 2026 at 04:42
Status:
Reviewed & tested by the community
» Needs work
Status
File
Size
new
3581109-nr-bot_0qwx6b3y.txt
91 bytes
The
Needs Review Queue Bot
tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the
Drupal Contributor Guide
to find step-by-step guides for working with issues.
or
to post comments
Comment
#17
quietone
commented
21 April 2026 at 05:59
Status:
Needs work
» Reviewed & tested by the community
The rebase was to remove update tests removed in
#3580877: Remove updates added prior to 11.3.0 from 12.x
. Since that was straightforward I am restoring the RTBC
or
to post comments
Comment
#18
needs-review-queue-bot
commented
21 April 2026 at 16:01
Status:
Reviewed & tested by the community
» Needs work
Status
File
Size
new
3581109-nr-bot_qmwtydqp.txt
98 bytes
The
Needs Review Queue Bot
tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the
Drupal Contributor Guide
to find step-by-step guides for working with issues.
or
to post comments
Comment
#19
godotislate
he/him
commented
21 April 2026 at 16:12
A few comments on the MR. It also has a merge conflict.
or
to post comments
Comment
#20
quietone
commented
22 April 2026 at 02:45
Status:
Needs work
» Needs review
@godotislate, thanks!
or
to post comments
Comment
#21
dcam
commented
22 April 2026 at 03:37
Status:
Needs review
» Reviewed & tested by the community
The applied suggestions looks good to me. The change to the fixture makes sense too since the module would not be installed in any core fixture.
or
to post comments
Comment
#22
22 April 2026 at 21:40
godotislate
closed
merge request !15184
or
to post comments
Comment
#23
22 April 2026 at 21:40
godotislate
committed
317a6474
on
main
task: #3581109 Move HelpSearch to Search sub-module

By: quietone
By:...
or
to post comments
Comment
#24
godotislate
he/him
commented
22 April 2026 at 21:40
Status:
Reviewed & tested by the community
» Fixed
Committed
317a647
and pushed to main. Thanks!
or
to post comments
Comment
#25
22 April 2026 at 21:40
Now that this issue is closed,
review the
contribution record
As a contributor, attribute any organization that helped you, or if you volunteered your own time.
Maintainers, credit people who helped resolve this issue.
or
to post comments
Comment
#26
23 April 2026 at 19:54
godotislate
committed
3d0c1dae
on
main
Revert "task: #3581109 Move HelpSearch to Search sub-module"

This...
or
to post comments
Comment
#27
godotislate
he/him
commented
23 April 2026 at 19:58
Status:
Fixed
» Needs work
Reverted, because this was causing very slow runs in CI:
Credited @amateescu and @nicxvan for finding/investigating.
or
to post comments
Comment
#28
23 April 2026 at 20:44
godotislate
committed
bc0673ec
on
main
task: #3581109 Move HelpSearch to Search sub-module

By: quietone
By:...
or
to post comments
Comment
#29
godotislate
he/him
commented
23 April 2026 at 20:46
Status:
Needs work
» Fixed
Never mind! It was
#3496257: Race conditions in CacheCollector/State (again)
causing the slowness in HelpTopicsSyntaxTest.
Committed
bc0673e
and pushed to main
or
to post comments
Comment
#30
23 April 2026 at 20:46
Now that this issue is closed,
review the
contribution record
As a contributor, attribute any organization that helped you, or if you volunteered your own time.
Maintainers, credit people who helped resolve this issue.
or
to post comments
Comment
#31
catch
he/him
commented
24 April 2026 at 13:02
Status:
Fixed
» Needs work
Re-opening for a different problem:
core/modules/search/modules/search_help/tests/src/Kernal/HelpSearchPluginTest.php
We need a quick follow-up to rename the directory. The namespace in the class itself is OK.
or
to post comments
Contribution record
Parent issue
Add child issue
clone issue
Infrastructure management for Drupal.org provided by
Need a Drupal 7 extended support partner? Consider Tag1.
News items
News
Planet Drupal
Social media
Sign up for Drupal news
Security advisories
Jobs
Our community
Community
Services
Training
Hosting
Contributor guide
Groups & meetups
DrupalCon
Code of conduct
Documentation
Documentation
Drupal Guide
Drupal User Guide
Developer docs
API.Drupal.org
Drupal code base
Download & Extend
Drupal core
Modules
Themes
Distributions
Governance of community
About
Web accessibility
Drupal Association
About Drupal.org
Drupal is a
registered trademark
of
Dries Buytaert