⚓ T249861 Make it possible to customize the default signature format per wiki

⚓ T249861 Make it possible to customize the default signature format per wiki
Page Menu
Phabricator
Create Task
Maniphest
T249861
Make it possible to customize the default signature format per wiki
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Esanders
Authored By
Whatamidoing-WMF
Apr 9 2020, 7:16 PM
2020-04-09 19:16:31 (UTC+0)
Tags
DiscussionTools
(Backlog)
OWC2020 (OWC2020 Replying 1.0)
(Needs Prioritization)
Editing-team (Q3 2019-2020 Kanban Board)
(Ready for Sign Off)
Skipped QA
MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)
Referenced Files
None
Subscribers
Aklapper
Dyolf77_WMF
Esanders
Patriccck
ppelberg
Samat
Tacsipacsi
View All 9 Subscribers
Description
Reported by User:ネイ at
Context
Some editors, and some wikis, have strong views about the "correct" way to sign a comment. Early Wikipedia conventions were similar to USENET e-mail conventions, with a pair of hyper-minus characters indicating the separation point between content and signature. These often map with how (in)convenient typing tildes are on their keyboard, because the signature button in the 2006 and 2010 wikitext editors includes the pair of hyphen-minuses, while people who type the tildes directly don't bother typing the hyphen-minuses.
As a result, there are at least three common signature styles:
Most editors at most wikis:
~~~~
Some editors at most wikis:
--~~~~
Most editors at some wikis, especially jawiki and cswiki:
--~~~~
(no space; the "period" is U+3002 and contains the space.)
It might be good, at least at wikis where a convention is strong, to be able to set the default.
Open questions
How should this configuration be implemented? As a core message? Something else?
See:
T249861#6078336
Requirements
Configurations that prevent the comment parser from being able to identify a signature should be disallowed.
Done
Individual wikis are able to customize what signature syntax the
DiscussionTools
output automatically
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Make signature prefix customisable
mediawiki/extensions/DiscussionTools
master
+19
-4
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T252258: Determine what technical requirements must be met before #DiscussionTools can be deployed to a new wiki
Mentioned Here
T245225: Implement editing specific comments
T249579: [EPIC] Usability improvements: make the actions, activity and content within talk pages easier to understand
Event Timeline
Whatamidoing-WMF
created this task.
Apr 9 2020, 7:16 PM
2020-04-09 19:16:31 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Apr 9 2020, 7:16 PM
2020-04-09 19:16:31 (UTC+0)
Patriccck
updated the task description.
(Show Details)
Apr 14 2020, 5:42 AM
2020-04-14 05:42:23 (UTC+0)
Patriccck
subscribed.
Tgr
subscribed.
Apr 22 2020, 2:40 PM
2020-04-22 14:40:17 (UTC+0)
Comment Actions
Typographic conventions change language to language. Hungarian, for example, uses a single en dash (
) instead of the
--
, and a non-breaking space to separate it from the signature.
There should really be a core message to customize this, instead of a dozen different extensions
trying to reimplement it by hand
ppelberg
added projects:
OWC2020 (OWC2020 Replying 1.0)
Editing-team
Apr 28 2020, 1:56 AM
2020-04-28 01:56:56 (UTC+0)
ppelberg
subscribed.
Apr 28 2020, 9:07 PM
2020-04-28 21:07:35 (UTC+0)
ppelberg
edited projects, added
Editing-team (Q3 2019-2020 Kanban Board)
; removed
Editing-team
May 2 2020, 1:10 AM
2020-05-02 01:10:53 (UTC+0)
ppelberg
added a comment.
May 15 2020, 6:30 PM
2020-05-15 18:30:20 (UTC+0)
Comment Actions
Notes from this week's team meeting
There are two key benefits of enabling wikis to customize the signature syntax
DiscussionTools
outputs:
Primary: making DT signature outputs customizable honors local conventions
Secondary: codifying signature prefixes (e.g.
--
or
) would enable the comment parser to different between a comment's signature and body with more certainty. This will be helpful when we think about the following:
T245225: Implement editing specific comments
: becomes easier to just expose the comment body
T249579: [EPIC] Usability improvements: make the actions, activity and content within talk pages easier to understand
: becomes easier to specify how the signature is presented on the page
ppelberg
added a comment.
Edited
May 15 2020, 6:32 PM
2020-05-15 18:32:19 (UTC+0)
Comment Actions
In
T249861#6078336
@Tgr
wrote:
Typographic conventions change language to language. Hungarian, for example, uses a single en dash (
) instead of the
--
, and a non-breaking space to separate it from the signature.
Good call. Thank you for adding this context,
@Tgr
There should really be a core message to customize this, instead of a dozen different extensions
trying to reimplement it by hand
This sounds like a consideration for how this functionality gets implemented. Assuming this to be true, I've tried to represent it as an "Open question" in the task description; please let me know if you think it needs to be adjusted or if I've assumed incorrectly.
ppelberg
updated the task description.
(Show Details)
May 15 2020, 6:41 PM
2020-05-15 18:41:54 (UTC+0)
ppelberg
moved this task from
Needs Discussion / Investigation
to
Ready for Development
on the
Editing-team (Q3 2019-2020 Kanban Board)
board.
gerritbot
added a comment.
May 20 2020, 12:23 PM
2020-05-20 12:23:13 (UTC+0)
Comment Actions
Change 597533 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Make signature prefix customisable
gerritbot
added a project:
Patch-For-Review
May 20 2020, 12:23 PM
2020-05-20 12:23:14 (UTC+0)
Esanders
moved this task from
Ready for Development
to
Code Review
on the
Editing-team (Q3 2019-2020 Kanban Board)
board.
May 20 2020, 12:23 PM
2020-05-20 12:23:23 (UTC+0)
Esanders
subscribed.
May 20 2020, 12:27 PM
2020-05-20 12:27:06 (UTC+0)
Comment Actions
In
T249861#6078336
@Tgr
wrote:
There should really be a core message to customize this, instead of a dozen different extensions
trying to reimplement it by hand
That would be nice but there are a lot of use cases there, and I wouldn't want our work tied up with a config change that could affect dozens of other extensions. We can create a separate task for that and migrate our implementation to a core variable later.
Esanders
claimed this task.
May 20 2020, 12:28 PM
2020-05-20 12:28:16 (UTC+0)
ppelberg
mentioned this in
T252258: Determine what technical requirements must be met before #DiscussionTools can be deployed to a new wiki
May 22 2020, 9:49 PM
2020-05-22 21:49:20 (UTC+0)
gerritbot
added a comment.
Jun 1 2020, 5:18 PM
2020-06-01 17:18:05 (UTC+0)
Comment Actions
Change 597533
merged
by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Make signature prefix customisable
matmarex
moved this task from
Code Review
to
Ready for Sign Off
on the
Editing-team (Q3 2019-2020 Kanban Board)
board.
Jun 1 2020, 5:35 PM
2020-06-01 17:35:53 (UTC+0)
matmarex
edited projects, added
Skipped QA
; removed
Patch-For-Review
ReleaseTaggerBot
added a project:
MW-1.35-notes (1.35.0-wmf.35; 2020-06-02)
Jun 1 2020, 6:00 PM
2020-06-01 18:00:25 (UTC+0)
ppelberg
closed this task as
Resolved
Jun 5 2020, 1:21 AM
2020-06-05 01:21:06 (UTC+0)
Dyolf77_WMF
subscribed.
Jul 24 2020, 10:23 AM
2020-07-24 10:23:13 (UTC+0)
Whatamidoing-WMF
added a comment.
Edited
Aug 10 2020, 12:18 AM
2020-08-10 00:18:48 (UTC+0)
Comment Actions
In case anyone wants to use this feature, you need to create a page called "MediaWiki:Discussiontools-signature-prefix" that contains your 'thing' (e.g., an endash, a non-breaking space, etc.).
Samat
subscribed.
Edited
Aug 10 2020, 8:54 PM
2020-08-10 20:54:53 (UTC+0)
Comment Actions
Is there a way that the Discussions Tool will use the signature setting set up in the user preferences?
Does it make sense?
Tacsipacsi
subscribed.
Aug 10 2020, 9:36 PM
2020-08-10 21:36:30 (UTC+0)
Comment Actions
In
T249861#6374494
@Samat
wrote:
Is there a way that the Discussions Tool will use the signature setting set up in the user preferences?
As far as I know, it does use it. It appends
~~~~
to the message (which is processed by MediaWiki core); this task is about using something like
--~~~~
instead of
~~~~
Whatamidoing-WMF
added a comment.
Aug 12 2020, 5:28 PM
2020-08-12 17:28:56 (UTC+0)
Comment Actions
Yes, you should get your custom signature already. But it's just the custom signature, and some wikis want a dash or a particular kind of space. If you do nothing, then the default is
~~~~
(a single normal space followed by your custom signature and the timestamp).
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits