⚓ T261391 Use standard external link icon for external links

⚓ T261391 Use standard external link icon for external links
Page Menu
Phabricator
Create Task
Maniphest
T261391
Use standard external link icon for external links
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Volker_E
Authored By
Volker_E
Aug 27 2020, 10:20 AM
2020-08-27 10:20:54 (UTC+0)
Tags
Design
(Incoming)
UI-Standardization
(Unsorted)
MediaWiki-General
(Backlog)
Vector (legacy skin)
(Design)
Web-Team-Backlog-Archived
(Tracking)
Design-System-Team (Design-System-Sprint)
(Pending Release)
MW-1.39-notes (1.39.0-wmf.27; 2022-08-29)
MW-1.40-notes (1.40.0-wmf.1; 2022-09-12)
Referenced Files
F35517419: link-external-small-ltr-progressive.svg
Sep 12 2022, 5:52 AM
2022-09-12 05:52:23 (UTC+0)
F35517418: link-external-small-rtl-progressive.svg
Sep 12 2022, 5:52 AM
2022-09-12 05:52:23 (UTC+0)
F35509580: ExternalLink-icon_SVG.zip
Sep 5 2022, 8:40 AM
2022-09-05 08:40:46 (UTC+0)
F35509577: ExternalLink-icon_SVG.zip
Sep 5 2022, 8:40 AM
2022-09-05 08:40:06 (UTC+0)
F35509514: ExternalLink_SVG.zip
Sep 5 2022, 7:42 AM
2022-09-05 07:42:35 (UTC+0)
F35509509: Captura de Pantalla 2022-09-05 a las 9.36.12.png
Sep 5 2022, 7:42 AM
2022-09-05 07:42:35 (UTC+0)
F35506402: link-external-small-ltr-progressive.png
Sep 2 2022, 2:22 AM
2022-09-02 02:22:33 (UTC+0)
F35491650: Captura de Pantalla 2022-08-26 a las 16.09.47.png
Aug 26 2022, 2:10 PM
2022-08-26 14:10:35 (UTC+0)
View All 42 Files
Subscribers
0xDeadbeef
Agusbou2015
Ahecht
Aklapper
alexhollender_WMF
alistair3149
bmartinezcalvo
View All 39 Subscribers
Description
Issue
One of the icons currently
not following
Wikimedia DSG's icon guidelines
is external link icon:
This is part of a longer-going unification of icons in
T55733
New, icon guidelines adhering external link icon:
Proposal
Before
After
NOTE:
This change is going into production for both Vector legacy and Vector 2022! Our proposed standard icon features simpler shapes in alignment with our
icon principles
to be better recognizable on small canvas.
Design notes
In order to cater appropriately to lo-dpi screens, we need to redraw the default external link icon of our collection to 12x12px canvas.
Here's the
latest Figma file
. Note that we don't leave a 1px spacing on the indicator canvas (in contrast to icons) for a rectangle in order to result in even stroke SVG points for the arrow and make better use of space at this small size.
Also note, that we will have to redo the icon another time when the content font-size is going to be increased in Vector 2022.
Developer notes
Ensure that we use Accent/link color for icon as it is part of the clickable area
Use smaller version of the icon (an OOUI indicator following 12px canvas) to provide crispiness on lo-dpi screens
Use 15px padding-[right in LTR/left in RTL]
em
equivalent for placing icon in link correctly. Preferred over 16 in Vector base font-size environment.
Remove external link treatment from MW core. That's skin area and shouldn't live in MW core.
Note that icon color
is always shown in normal link color
. Visited styling is not possible due to
browser security & user privacy limitations of styling link states in combination with server image requests
This is acceptable as it's no difference to current external icon treatment.
Acceptance criteria (or Done)
Note that there was a
enwiki Village Pump discussion
about not accepting the original iteration of the icon change, which WMF employees reverted due to technical errors.
Design
Design the new icon and ensure it follows our
icon system guidelines
In the course of this task, we've together with volunteers have identified minor improvements to the icon like arrow coming out of frame, which will also be brought back to our icon collection assets
Design the RTL icon
Export the icon as an optimized SVG and add it in this task description
ExternalLink-icon_SVG.zip
1 KB
Add the new icon in our
Icon System Figma file
and publish the library with the new icon added
Code
Update Vector to use the new icon
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
styles: Unify on standard external link icon (re-applying)
mediawiki/skins/Vector
master
+23
-15
icons: Fix arrow stem to be perfectly 45 degrees
mediawiki/skins/Vector
master
+2
-2
[modern][styles] Use default Design Style Guide link color choice
mediawiki/skins/Vector
master
+52
-4
Revert "styles: Unify on standard external link icon"
mediawiki/skins/Vector
wmf/1.39.0-wmf.22
+15
-23
Revert "styles: Unify on standard external link icon"
mediawiki/skins/Vector
master
+15
-23
styles: Unify on standard external link icon
mediawiki/skins/Vector
master
+24
-15
icons: Amend external link icon for lo-dpi screens
mediawiki/skins/Vector
master
+5
-9
styles: Unify on standard external link icon
mediawiki/skins/Vector
master
+25
-20
styles: Make external icon indicator size for lo-dpi environments
mediawiki/skins/Vector
master
+14
-10
ResourceLoaderSkinModule can use icons
mediawiki/core
master
+90
-2
External link and error icons come from core
mediawiki/skins/MinervaNeue
master
+16
-26
Vector's external link icon comes from ResourceLoaderSkinModule
mediawiki/skins/Vector
master
+1
-13
Show related patches
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Duplicates
Status
Subtype
Assigned
Task
Open
None
T55733
Use the same icons to represent the same things (tracking)
Open
None
T298433
Is it useful to have different icons for protocol, documents and media file external links?
Resolved
Volker_E
T261391
Use standard external link icon for external links
Resolved
Volker_E
T298431
Remove external link treatment from `.link-https` carrying links
Mentioned In
T318374: Design input needed: Use external link icon for chat/video links
T313562: Design review the visual enhancement and layout changes
T310241: Migrate QuickSurveys from WVUI to Codex
T313459: Changes to link color and icon
T244558: ResourceLoaderOOUIIconPackModule doesn't allow mixing of images and icons
T294910: Icon changes for QuickSurveys
Mentioned Here
T55733: Use the same icons to represent the same things (tracking)
T261334: [Goal] Font-size: Use `rem` in modern Vector
Duplicates Merged Here
T278196: Replace Vector's legacy external link icon with WikimediaUI's default
Event Timeline
There are a very large number of changes, so older changes are hidden.
Show Older Changes
bmartinezcalvo
added a comment.
Aug 8 2022, 5:29 PM
2022-08-08 17:29:22 (UTC+0)
Comment Actions
In
T261391#8117116
@Nikki
wrote:
Personally I think the new icon looks unbalanced. The arrow is smaller while the box is much larger and my eye is drawn more to the box than the arrow. If it were up to me, I would make the box a bit smaller and the arrow a bit larger, something like this:
Doing that also makes it more obvious to me that the arrow is coming out of the box, rather than pointing at the top right corner of it.
Following this feedback from
@Nikki
I've created
this new proposal
for the External Link icon with a smaller box and bigger arrow.
And this is how it would look like in 100% zoom with pixel preview.
Jdlrobson
moved this task from
Needs More Work
to
Blocked on Others
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 8 2022, 9:46 PM
2022-08-08 21:46:58 (UTC+0)
gerritbot
added a comment.
Aug 17 2022, 5:46 PM
2022-08-17 17:46:17 (UTC+0)
Comment Actions
Change 824251 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/skins/Vector@master] styles: Unify on standard external link icon (re-applying)
PatchDemoBot
added a comment.
Aug 17 2022, 8:45 PM
2022-08-17 20:45:10 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by Jdlrobson using patch(es) linked to this task:
Jdlrobson
reassigned this task from
Volker_E
to
alexhollender_WMF
Aug 17 2022, 8:56 PM
2022-08-17 20:56:27 (UTC+0)
Jdlrobson
moved this task from
Blocked on Others
to
Design Review
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Comment Actions
Alex could you take a look at the patchdemo and move to needs more work or code review depending on what you think? Thanks in advance!
bmartinezcalvo
added a comment.
Edited
Aug 18 2022, 7:36 AM
2022-08-18 07:36:08 (UTC+0)
Comment Actions
I've reviewed
the last patch
and the icon looks unbalanced next to bold link text.
{F35470996}
Volker_E
added a comment.
Edited
Aug 18 2022, 8:01 AM
2022-08-18 08:01:46 (UTC+0)
Comment Actions
@bmartinezcalvo
Yes, that's right. The current implementation of the external link icon is very limited though and doesn't cover a number of special cases (italics, visited) etc. But boldened external links are also the absolute exception of the rule. It doesn't make sense from a code and performance perspective to expand on the CSS for this (right now).
Also, the background-sizing wasn't complete yet in the first WIP patch. Please have another look with the updated patch.
In
T261391#8111726
@TheDJ
wrote:
In
T261391#8105563
@Volker_E
wrote:
Assuming this unevenness between width of left border and bottom border relates to this problem as well?
Yes, the borders on canvas boundaries were part of the issue. The updated icon has resolved that issue.
That 0.75em of (in this example) 14px (making 10.5px) background sizing of a natively sized 12px element is less than ideal because it causes rounding errors it seems. Maybe we should natively make it 16x16px, before the scaling apply for
@2x
hidpi and adapting to the font size ? We want to make it as simple as possible for the browser to clamp to a full pixel value when resizing.
It's mostly a wrong variable used in the original patch, with the new calculation we feature the right background size equivalent of 12px in
em
with the right icon canvas.
I'm not aware of any parser output font-size changes from the Vector default, besides maybe a few quirky templates, which would feature external links. Do you on top of your head
@TheDJ
The mid-term way out is clearly
T261334: [Goal] Font-size: Use `rem` in modern Vector
alexhollender_WMF
reassigned this task from
alexhollender_WMF
to
Volker_E
Aug 23 2022, 5:14 PM
2022-08-23 17:14:42 (UTC+0)
alexhollender_WMF
moved this task from
Design Review
to
Needs More Work
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Comment Actions
(assuming from the latest comments that this is still being worked on)
ovasileva
edited projects, added
Web-Team-Backlog-Archived
; removed
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
Aug 23 2022, 5:21 PM
2022-08-23 17:21:08 (UTC+0)
Comment Actions
Moving out of the board for now,
@Volker_E
- feel free to move it back once it's ready for code review and design review!
ovasileva
moved this task from
Not ready to estimate
to
Tracking
on the
Web-Team-Backlog-Archived
board.
Aug 23 2022, 5:21 PM
2022-08-23 17:21:19 (UTC+0)
bmartinezcalvo
updated the task description.
(Show Details)
Aug 23 2022, 5:31 PM
2022-08-23 17:31:59 (UTC+0)
PatchDemoBot
added a comment.
Aug 23 2022, 8:58 PM
2022-08-23 20:58:58 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by Volker E. (WMF) using patch(es) linked to this task:
Volker_E
added a comment.
Aug 23 2022, 9:00 PM
2022-08-23 21:00:51 (UTC+0)
Comment Actions
@alexhollender_WMF
@ovasileva
Patch has been updated four days ago, above patch demo shows the latest.
Volker_E
added a project:
Design-System-Team (Design-System-Sprint)
Aug 23 2022, 9:18 PM
2022-08-23 21:18:17 (UTC+0)
Volker_E
updated the task description.
(Show Details)
Volker_E
updated the task description.
(Show Details)
Aug 23 2022, 9:21 PM
2022-08-23 21:21:30 (UTC+0)
Volker_E
updated the task description.
(Show Details)
Aug 23 2022, 9:29 PM
2022-08-23 21:29:03 (UTC+0)
Volker_E
reassigned this task from
Volker_E
to
Sarai-WMDE
Aug 25 2022, 12:13 AM
2022-08-25 00:13:04 (UTC+0)
Volker_E
reassigned this task from
Sarai-WMDE
to
alexhollender_WMF
Volker_E
reassigned this task from
alexhollender_WMF
to
Sarai-WMDE
Volker_E
reassigned this task from
Sarai-WMDE
to
alexhollender_WMF
Volker_E
moved this task from
Committed
to
Design Sign-Off
on the
Design-System-Team (Design-System-Sprint)
board.
Volker_E
added a subscriber:
Sarai-WMDE
alexhollender_WMF
added a comment.
Aug 25 2022, 12:19 AM
2022-08-25 00:19:51 (UTC+0)
Comment Actions
looks good to me. what do you think
@bmartinezcalvo
bmartinezcalvo
updated the task description.
(Show Details)
Aug 26 2022, 2:07 PM
2022-08-26 14:07:47 (UTC+0)
bmartinezcalvo
added a comment.
Aug 26 2022, 2:10 PM
2022-08-26 14:10:35 (UTC+0)
Comment Actions
In
T261391#8183672
@alexhollender_WMF
wrote:
looks good to me. what do you think
@bmartinezcalvo
Reviewed last patch. It looks good to me too.
I've added the new 12px External Link icon (both LTR-RTL versions) in our
Icon System Figma file
so we can use it in our design projects. I've also exported both LTR and RTL icons and added them in the task description.
alexhollender_WMF
reassigned this task from
alexhollender_WMF
to
ldelench_wmf
Aug 26 2022, 3:14 PM
2022-08-26 15:14:15 (UTC+0)
alexhollender_WMF
moved this task from
Design Sign-Off
to
Product Sign-Off
on the
Design-System-Team (Design-System-Sprint)
board.
Comment Actions
(cc
@ovasileva
@Jdlrobson
this has been design reviewed and is ready to go)
gerritbot
added a comment.
Aug 26 2022, 4:29 PM
2022-08-26 16:29:23 (UTC+0)
Comment Actions
Change 824251
merged
by jenkins-bot:
[mediawiki/skins/Vector@master] styles: Unify on standard external link icon (re-applying)
ReleaseTaggerBot
edited projects, added
MW-1.39-notes (1.39.0-wmf.27; 2022-08-29)
; removed
MW-1.39-notes (1.39.0-wmf.22; 2022-07-25)
Aug 26 2022, 5:00 PM
2022-08-26 17:00:08 (UTC+0)
ldelench_wmf
reassigned this task from
ldelench_wmf
to
DAbad
Aug 29 2022, 2:11 PM
2022-08-29 14:11:20 (UTC+0)
ldelench_wmf
subscribed.
Maintenance_bot
removed a project:
Patch-For-Review
Aug 29 2022, 2:31 PM
2022-08-29 14:31:21 (UTC+0)
DAbad
moved this task from
Product Sign-Off
to
Pending Release
on the
Design-System-Team (Design-System-Sprint)
board.
Sep 1 2022, 3:17 PM
2022-09-01 15:17:15 (UTC+0)
Comment Actions
Product sign-off complete
Pythoncoder
unsubscribed.
Sep 1 2022, 7:05 PM
2022-09-01 19:05:38 (UTC+0)
Nardog
added a comment.
Sep 2 2022, 2:22 AM
2022-09-02 02:22:33 (UTC+0)
Comment Actions
The new SVG is still weird in several ways. The stem of the arrow is not centered, its intersection with the arrowhead is not perpendicular on one side, and the starting point of the arrow is not cut 45 degrees. (There's also a node that's completely unnecessary in the arrowhead.)
alexhollender_WMF
added a comment.
Sep 2 2022, 4:56 PM
2022-09-02 16:56:08 (UTC+0)
Comment Actions
@bmartinezcalvo
would you be able to respond to
@Nardog
's comments above, and possibly provided an updated SVG?
bmartinezcalvo
added a comment.
Sep 5 2022, 7:42 AM
2022-09-05 07:42:35 (UTC+0)
Comment Actions
@Nardog
thank you for your comment, I've updated the icon with the corrections you commented:
Aligned the arrow line with the arrow center
Checked the 45º of the arrow line
Deleted the extra node of the arrow
Here you can find the new exported SVG icon. If all it's ok with this new icon I will update it in our
Figma library
ExternalLink_SVG.zip
1 KB
Nardog
added a comment.
Sep 5 2022, 8:20 AM
2022-09-05 08:20:15 (UTC+0)
Comment Actions
Looks good, the stem is ever so slightly off the center and it's not exactly 1px wide (when you straighten it back), but I assume those are effects of optimization.
bmartinezcalvo
added a comment.
Sep 5 2022, 8:40 AM
2022-09-05 08:40:06 (UTC+0)
Comment Actions
In
T261391#8210739
@Nardog
wrote:
Looks good, the stem is ever so slightly off the center and it's not exactly 1px wide (when you straighten it back), but I assume those are effects of optimization.
@Nardog
I think the previous icon changed a bit when I flattened the shapes. So I've update it a bit and exported it again. Please let me know if all it's ok now.
ExternalLink-icon_SVG.zip
1 KB
bmartinezcalvo
updated the task description.
(Show Details)
Sep 5 2022, 8:40 AM
2022-09-05 08:40:46 (UTC+0)
alexhollender_WMF
added a comment.
Sep 5 2022, 2:18 PM
2022-09-05 14:18:10 (UTC+0)
Comment Actions
thanks for these comments
@Nardog
and the updated icon
@bmartinezcalvo
@Volker_E
@Jdlrobson
what needs to be done in order to deploy the updated version of the icon?
cc
@ovasileva
Nardog
added a comment.
Sep 5 2022, 2:21 PM
2022-09-05 14:21:13 (UTC+0)
Comment Actions
@bmartinezcalvo
Now it is centered and 1px. :) LGTM.
Jdlrobson
moved this task from
Tracking
to
Not ready to estimate
on the
Web-Team-Backlog-Archived
board.
Sep 6 2022, 4:44 PM
2022-09-06 16:44:57 (UTC+0)
Mhawk10
subscribed.
Sep 7 2022, 5:22 AM
2022-09-07 05:22:40 (UTC+0)
Comment Actions
A discussion on the English Wikipedia's village pump
closed
as there being consensus against implementing the new external links icon on EnWiki. In light of this, I do not think it's appropriate to deploy this change to the English Wikipedia.
Jdlrobson
added a comment.
Sep 7 2022, 4:51 PM
2022-09-07 16:51:44 (UTC+0)
Comment Actions
@Mhawk10
how are you evaluating consensus on that discussion?
Rexogamer
subscribed.
Sep 7 2022, 4:57 PM
2022-09-07 16:57:39 (UTC+0)
Comment Actions
My personal reading of that discussion was that it was largely a reaction to the previous, broken version of the icon and that most people were opposed to it because it was the broken version - I suspect that, if reran now, the RFC would have a different result. The consensus also doesn't feel that clear-cut to me - I see quite a few people in favour of the new icon, so I'm not entirely convinced that it was accurately evaluated/closed.
Mhawk10
added a comment.
Sep 8 2022, 2:33 AM
2022-09-08 02:33:47 (UTC+0)
Comment Actions
@Jdlrobson
@Remagoxer
My reading of consensus is that of the closing summary, that:
There is consensus to keep the old icon
and, while it can be improved,,
the community would prefer approving a new icon, or having input on the design, before implementation
If you disagree with the reading of consensus from the closer, that's fine, but that's also something to discuss with the closer or to challenge at AN. That isn't something to completely ignore, given that it was closed less than five days ago. Frankly, the EnWiki community hasn't approved the new logo, so I'm a bit floored at the idea that we would ignore such a recent consensus that was achieved on-wiki.
Nardog
added a comment.
Sep 8 2022, 2:45 AM
2022-09-08 02:45:57 (UTC+0)
Comment Actions
If the closer's assessment of the discussion is to be implemented, it should be achieved by interface administrators editing the wiki-specific skin CSS, not by blocking a patch altogether.
Jdlrobson
added a comment.
Edited
Sep 8 2022, 4:10 PM
2022-09-08 16:10:45 (UTC+0)
Comment Actions
My reading of the discussion was a new SVG with a bug was released, that was reverted around the same time as the RFC. This led to a lot of confusion and as a result the RFC was inconclusive.
As
@Nardog
says, regardless of the outcome if that was the RFC conclusion the next step would be to ask an interface administrators to edit MediaWiki:Common.css to override the icon. The RFC was on English Wikipedia only so shouldn't impact other projects or the software itself.
gerritbot
added a comment.
Sep 9 2022, 3:54 AM
2022-09-09 03:54:31 (UTC+0)
Comment Actions
Change 622763
abandoned
by VolkerE:
[mediawiki/skins/Vector@master] [modern][styles] Use default Design Style Guide link color choice
Reason:
Superseded by I8a309eedd70b9a82f
Volker_E
added a comment.
Sep 12 2022, 5:52 AM
2022-09-12 05:52:23 (UTC+0)
Comment Actions
Another time here, the two optimized left and right directionality icons with updated arrow/arrowheads and SVGO and manually optimized (cc:
@Nardog
):
link-external-small-rtl-progressive.svg
305 B
link-external-small-ltr-progressive.svg
304 B
gerritbot
added a comment.
Sep 12 2022, 6:24 AM
2022-09-12 06:24:39 (UTC+0)
Comment Actions
Change 831371 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/skins/Vector@master] icons: Fix arrow stem to be perfectly 45 degrees
gerritbot
added a project:
Patch-For-Review
Sep 12 2022, 6:24 AM
2022-09-12 06:24:40 (UTC+0)
ovasileva
moved this task from
Not ready to estimate
to
Tracking
on the
Web-Team-Backlog-Archived
board.
Sep 12 2022, 7:11 AM
2022-09-12 07:11:23 (UTC+0)
ldelench_wmf
moved this task from
Pending Release
to
Product Sign-Off
on the
Design-System-Team (Design-System-Sprint)
board.
Sep 12 2022, 4:14 PM
2022-09-12 16:14:57 (UTC+0)
gerritbot
added a comment.
Sep 12 2022, 4:59 PM
2022-09-12 16:59:49 (UTC+0)
Comment Actions
Change 831371
merged
by jenkins-bot:
[mediawiki/skins/Vector@master] icons: Fix arrow stem to be perfectly 45 degrees
ReleaseTaggerBot
added a project:
MW-1.40-notes (1.40.0-wmf.1; 2022-09-12)
Sep 12 2022, 5:00 PM
2022-09-12 17:00:43 (UTC+0)
Volker_E
updated the task description.
(Show Details)
Sep 20 2022, 12:24 AM
2022-09-20 00:24:26 (UTC+0)
Volker_E
updated the task description.
(Show Details)
Sep 20 2022, 7:52 AM
2022-09-20 07:52:55 (UTC+0)
Volker_E
removed a project:
Patch-For-Review
Comment Actions
I've updated
enwiki VillagePump with amended icon release notice
and there has been no negative feedback since. Only one community member asking how to help in future tests.
Izno
added a comment.
Sep 20 2022, 5:21 PM
2022-09-20 17:21:29 (UTC+0)
Comment Actions
In
T261391#8247181
@Volker_E
wrote:
I've updated
enwiki VillagePump with amended icon release notice
and there has been no negative feedback since. Only one community member asking how to help in future tests.
The objection was on a different village pump. You should consider posting on that one instead, somewhere in the vicinity of
the discussion itself
HouseBlaster
unsubscribed.
Sep 21 2022, 1:10 AM
2022-09-21 01:10:16 (UTC+0)
Volker_E
added a comment.
Sep 21 2022, 6:54 AM
2022-09-21 06:54:42 (UTC+0)
Comment Actions
As the RfC was closed, it isn't good practice to add to it. In conversation with our community liaisons person, we've decided to put it on the Technical section. I've also pinged the author behind the RfC on their user page.
Izno
added a comment.
Sep 21 2022, 9:51 AM
2022-09-21 09:51:48 (UTC+0)
Comment Actions
In
T261391#8249752
@Volker_E
wrote:
As the RfC was closed, it isn't good practice to add to it. In conversation with our community liaisons person, we've decided to put it on the Technical section. I've also pinged the author behind the RfC on their user page.
It is common if not routine to add subsections to closed sections discussing remaining items. This was done for the section of interest at
"Implementing consensus"
for a separate reason, but there isn't really a reason of your own not to do so if you have a follow up.
Daimona
mentioned this in
T318374: Design input needed: Use external link icon for chat/video links
Oct 3 2022, 9:58 PM
2022-10-03 21:58:55 (UTC+0)
Volker_E
added a comment.
Oct 5 2022, 8:46 AM
2022-10-05 08:46:03 (UTC+0)
Comment Actions
@Izno
, the original revert of the first broken iteration and the coming amendments were all shared in
my long first post
to the “RFC”. After that the discussion seeing much less attention and other focus. I have responded here on the task with helpful and icon amending conversations with large group of volunteers, have brought it onto
Village Pump again
(as you mentioned in the “Technical”, not the “Proposals” section with only interested feedback responses and have pinged the original topic author on their personal talk page.
With that the change to unify this 12x12px icon as part of
T55733
our
221 icons
seems fairly resolvable.
Volker_E
closed this task as
Resolved
Oct 6 2022, 1:08 AM
2022-10-06 01:08:08 (UTC+0)
Volker_E
claimed this task.
Volker_E
updated the task description.
(Show Details)
Volker_E
added a subscriber:
DAbad
Stang
unsubscribed.
Oct 9 2022, 10:33 PM
2022-10-09 22:33:18 (UTC+0)
PatchDemoBot
added a comment.
Feb 3 2023, 3:40 PM
2023-02-03 15:40:55 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by Jdlrobson using patch(es) linked to this task was
deleted
PatchDemoBot
added a comment.
Feb 3 2023, 3:42 PM
2023-02-03 15:42:29 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by Volker E. (WMF) using patch(es) linked to this task was
deleted
Volker_E
moved this task from
Product Sign-Off
to
Pending Release
on the
Design-System-Team (Design-System-Sprint)
board.
Feb 13 2023, 5:42 PM
2023-02-13 17:42:25 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits