⚓ T285439 prefs-vector-enable-vector-1-help is broken if you delete default interwiki entries

⚓ T285439 prefs-vector-enable-vector-1-help is broken if you delete default interwiki entries
Page Menu
Phabricator
Create Task
Maniphest
T285439
prefs-vector-enable-vector-1-help is broken if you delete default interwiki entries
Closed, Resolved
Public
BUG REPORT
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Umherirrender
Authored By
Tenbergen
Jun 23 2021, 9:41 PM
2021-06-23 21:41:16 (UTC+0)
Tags
Vector (legacy skin) (Tracking)
I18n
(Untriaged)
MW-1.43-notes (1.43.0-wmf.6; 2024-05-21)
Referenced Files
F34524189: Screenshot 2021-06-23 at 23.36.45.png
Jun 23 2021, 10:37 PM
2021-06-23 22:37:42 (UTC+0)
Subscribers
Aklapper
Jdlrobson
Pppery
Reedy
Samwilson
Tenbergen
Description
List of steps to reproduce
(step by step, including full links if applicable):
go to Preferences, then appearance tab
under skin preferences, set skin to vector (if not already there) and see "Skin preferences"
there is a link to "project page", that's what I am referring to. For me it tries to go to my wiki, ie to
Possibly related: until very recently this wiki was only loading the monobook skin. I just started to have it load Vector to see if that will fix
, and this came up when I went to my preferences to test that.
Tried to find where it is supposed to link to but that's set of pages and subpages is a warren, so not sure which one.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc
MediaWiki 1.36.1
PHP 7.4.3 (cgi-fcgi)
MySQL 5.7.28-log
ICU 57.1
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
i18n: Replace mw: interwiki with url to mediawiki.org
mediawiki/skins/Vector
master
+3
-3
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T158585: The 'Wikitext "uses markup"' link doesn't work if the mw: interwiki is not configured
Mentioned Here
T240811: Prevent the deletion/modification of the 'mw' interwiki prefix
T273080: Stop managing both interwiki.list and interwiki.sql
T274267: Remove "Switch to old look" from the sidebar on the first-batch test wikis
T284715: "PHP Deprecated: Premature access to service" warnings in 1.36
Event Timeline
Tenbergen
created this task.
Jun 23 2021, 9:41 PM
2021-06-23 21:41:16 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Jun 23 2021, 9:41 PM
2021-06-23 21:41:17 (UTC+0)
Reedy
added a project:
Vector (legacy skin)
Jun 23 2021, 10:35 PM
2021-06-23 22:35:32 (UTC+0)
Reedy
subscribed.
Comment Actions
"prefs-vector-enable-vector-1-label"
"Use Legacy Vector"
"prefs-vector-enable-vector-1-help"
"Over the next few years, we will be gradually updating the Vector skin. Legacy Vector will allow you to view the old version of Vector (as of December 2019). To learn more about the updates, go to our [[mw:Reading/Web/Desktop_Improvements|project page]]."
Reedy
added a comment.
Jun 23 2021, 10:37 PM
2021-06-23 22:37:42 (UTC+0)
Comment Actions
Do you have an Mw namespace? Or is mw missing from your interwiki list?
Tenbergen
added a comment.
Jun 23 2021, 11:49 PM
2021-06-23 23:49:03 (UTC+0)
Comment Actions
I have a MediaWiki namespace, but no MW one.
Following the instructions in
if I run
I only see 4, and get another redlink to a [[mw: . And that then reminds me that years ago I probably purged the interwikis because there were 4 that I wanted and the rest had nothing to do with how we use our wiki. Does this mean I have to set up a interwiki link to the mediawiki wiki to fix interface error message links? If so, it would probably be good to add to
a hint that messing with some interwikis can break your wiki?
I understand why to abstract the links, but is it a good idea to do it with a prefix that isn't somehow protected?
Reedy
added a comment.
Jun 23 2021, 11:51 PM
2021-06-23 23:51:50 (UTC+0)
Comment Actions
I think it makes more sense to not use an interwiki syntax that can be changed/similar by third party wikis.
It should be a proper external URL so you're not relying on functionality that isn't guaranteed to exist on a third party wiki.
Reedy
renamed this task from
"Project Page" link in Preferences, Appearance, shows redlink because it goes to this private wiki rather than mediawiki.org
to
prefs-vector-enable-vector-1-help should use an external url, not an interwiki link
Jun 23 2021, 11:52 PM
2021-06-23 23:52:23 (UTC+0)
Tenbergen
added a comment.
Edited
Jun 23 2021, 11:53 PM
2021-06-23 23:53:25 (UTC+0)
Comment Actions
Will this ticket reach the people who would make such decisions about how these links are set up inside interface pages? Or do I need to do something else to flag this?
Because the comment is more widespread. The API link (
) to show me which interwikis there are also had its own redlinked [[mw: entry, so this might be a common practice.
Reedy
triaged this task as
Low
priority.
Jun 24 2021, 12:36 AM
2021-06-24 00:36:14 (UTC+0)
Comment Actions
That makes it a much larger issue, related to many different components.
Including all usages in all translations... There's 2461 usages in our hosted repos....
Reedy
renamed this task from
prefs-vector-enable-vector-1-help should use an external url, not an interwiki link
to
prefs-vector-enable-vector-1-help is broken if you delete default interwiki entries
Jun 24 2021, 12:37 AM
2021-06-24 00:37:10 (UTC+0)
Jdlrobson
edited projects, added
Wikimedia-Interwiki-links
Vector (legacy skin) (Tracking)
Web-Team-Backlog-Archived (Tracking)
; removed
Vector (legacy skin)
Jun 25 2021, 3:09 PM
2021-06-25 15:09:46 (UTC+0)
Jdlrobson
subscribed.
Comment Actions
For wikis in this situation I recommend simply updating the page [[ MediaWiki:prefs-vector-enable-vector-1-help ]] to reflect better text, or hiding the preference or text altogether.
We could update the i18n messages to use an external link, but that's a lot of messages to updating. This code is also temporary and might be removed/configurable soon: (
T274267
Adding interwiki tag in case there is some better way for us to resolve the use of interwikis across our projects. Perhaps
mw:
should be added by default?
Tenbergen
added a comment.
Jun 28 2021, 7:39 PM
2021-06-28 19:39:00 (UTC+0)
Comment Actions
For solution for anyone else who runs into this: running the following sql query to add the mw interwiki back in solved the direct problem for me:
INSERT INTO `mw_interwiki` (iw_prefix, iw_url, iw_local, iw_trans) VALUES ("mw", "https://www.mediawiki.org/wiki/$1", 0, 0)
But a better solution is likely needed for the underlying problem of many user interface pages linking via interwiki. That setup is easy to break inadvertently when cleaning out a table that contains a lot of legacy interwikis. Some don't even exist any longer (eg
) and the process by which sites are added or removed from the list is not addressed in
. That problem is probably out of the scope of this ticket, but if all the interwikis that are included by default were MWF wikis I likely wouldn't have cleaned it out.
Reedy
added a comment.
Jun 28 2021, 8:48 PM
2021-06-28 20:48:43 (UTC+0)
Comment Actions
There mostly isn't a process.
Even if they're updated in the canonical list inside MW core, MW doesn't update/re-integrate that (and hence doesn't add/remove/update rows). It's only used at install point.
If they're definitely dead, bugs filed or gerrit patches would be accepted to remove them.
See also:
T273080: Stop managing both interwiki.list and interwiki.sql
Jdlrobson
moved this task from
Untriaged
to
Untag
on the
Web-Team-Backlog-Archived (Tracking)
board.
Nov 9 2021, 4:45 PM
2021-11-09 16:45:46 (UTC+0)
Jdlrobson
removed a project:
Web-Team-Backlog-Archived (Tracking)
Dec 7 2021, 7:46 PM
2021-12-07 19:46:49 (UTC+0)
Pppery
removed a project:
Wikimedia-Interwiki-links
Apr 29 2024, 4:59 AM
2024-04-29 04:59:34 (UTC+0)
Pppery
added a project:
I18n
Pppery
subscribed.
Apr 29 2024, 5:06 AM
2024-04-29 05:06:30 (UTC+0)
Comment Actions
The other option is to decline this ticket, declare the people doing this are shooting themselves in the foot, and lock the footgun with
T240811
Tenbergen
added a comment.
Apr 30 2024, 12:42 AM
2024-04-30 00:42:16 (UTC+0)
Comment Actions
Mediawiki is also run behind firewalls or entirely offline, so that doesn't seem like a good idea. I was actually thinking it would be good if there was a simple switch or extension that would change a mediawiki to get rid of any links onto the internet.
gerritbot
added a comment.
May 15 2024, 8:57 PM
2024-05-15 20:57:21 (UTC+0)
Comment Actions
Change #1032044 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/skins/Vector@master] i18n: Replace mw: interwiki with url to mediawiki.org
gerritbot
added a project:
Patch-For-Review
May 15 2024, 8:57 PM
2024-05-15 20:57:22 (UTC+0)
Umherirrender
claimed this task.
May 15 2024, 9:05 PM
2024-05-15 21:05:09 (UTC+0)
gerritbot
added a comment.
May 15 2024, 9:27 PM
2024-05-15 21:27:27 (UTC+0)
Comment Actions
Change #1032044
merged
by jenkins-bot:
[mediawiki/skins/Vector@master] i18n: Replace mw: interwiki with url to mediawiki.org
Umherirrender
closed this task as
Resolved
May 15 2024, 9:30 PM
2024-05-15 21:30:25 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
May 15 2024, 9:30 PM
2024-05-15 21:30:49 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.43-notes (1.43.0-wmf.6; 2024-05-21)
May 15 2024, 10:00 PM
2024-05-15 22:00:39 (UTC+0)
Samwilson
subscribed.
May 27 2024, 6:54 PM
2024-05-27 18:54:31 (UTC+0)
Comment Actions
It sounds like a decision has been made here to
not
add
mw:
by default, and replace all occurrences of it in messages with full mediawiki.org URLs. Is that correct? Should
T240811
be declined?
Pppery
mentioned this in
T158585: The 'Wikitext "uses markup"' link doesn't work if the mw: interwiki is not configured
Jul 30 2024, 2:07 AM
2024-07-30 02:07:31 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits