⚓ T305411 Codex demo CSS should use default theme 'WikimediaUI' design tokens

⚓ T305411 Codex demo CSS should use default theme 'WikimediaUI' design tokens
Page Menu
Phabricator
Create Task
Maniphest
T305411
Codex demo CSS should use default theme 'WikimediaUI' design tokens
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Volker_E
Authored By
AnneT
Apr 4 2022, 9:02 PM
2022-04-04 21:02:53 (UTC+0)
Tags
Codex
(Backlog)
Documentation
(Backlog)
Design-System-Team (Design-System-Sprint)
(Pending Release)
Referenced Files
None
Subscribers
Aklapper
AnneT
ldelench_wmf
Sarai-WMDE
Volker_E
Description
Background
Right now, there's a
CSS file
for the
Codex
documentation site
that sets some basic styles, like font family and colors.
Goal
Codex documentation should itself make use of the Wikimedia Product design's choices, provided in “WikimediaUI” theme tokens. We need to use the tokens in this file to ensure things like
font-family
are correct and up-to-date.
In
T305411#8031712
@Volker_E
wrote:
This should be active as long as we don't have all essential tokens (size/spacing, typography aka font family, size, …, line height, breakpoints) merged. As long as we have non DS design-decision values in the demos, we should keep this open. It's more like an [EPIC] task IMO.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
docs: Use design tokens within codex-docs custom theme
design/codex
main
+31
-23
tokens, styles: Introduce design-first `font-size` tokens
design/codex
main
+73
-15
Update Codex from v0.5.0 to v0.6.0
mediawiki/core
master
+1 K
-1 K
docs: Refine visual hierarchy and use design-first heading styles
design/codex
main
+19
-3
docs: Refine visual hierarchy and use Codex tokens
design/codex
main
+51
-7
Update Codex from v0.4.3 to v0.5.0
mediawiki/core
master
+1 K
-1 K
Update Codex from v0.4.2 to v0.4.3
mediawiki/core
master
+30
-25
docs, tokens: Apply `line-height` tokens everywhere
design/codex
main
+22
-14
Update Codex from v0.2.2 to v0.3.0
mediawiki/core
master
+2 K
-1 K
docs: Replace calculation with spacing token
design/codex
main
+2
-1
Update Codex from v0.2.1 to v0.2.2
mediawiki/core
master
+1 K
-1 K
docs: Use Card styles (and its design tokens) on footer pager cards
design/codex
main
+30
-8
styles, docs: Replace static `text-decoration` values with Codex tokens
design/codex
main
+11
-11
docs, tokens: Replace deprecated design tokens
design/codex
main
+12
-13
docs: Set VitePress text color to `color-base`
design/codex
main
+1
-0
Show related patches
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Open
None
T304062
docs: Codex doc site visual design/user experience improvements
Resolved
Volker_E
T305411
Codex demo CSS should use default theme 'WikimediaUI' design tokens
Mentioned In
T319246: [SPIKE] Reassess Codex docs site technical implementation
T304566: Update TextInput to meet the Figma designs
T293127: [EPIC] Design System Foundation: Design and define design tokens
Mentioned Here
T325055: Improve the visual hierarchy between sections in Codex
T293127: [EPIC] Design System Foundation: Design and define design tokens
Event Timeline
AnneT
created this task.
Apr 4 2022, 9:02 PM
2022-04-04 21:02:53 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Apr 4 2022, 9:02 PM
2022-04-04 21:02:53 (UTC+0)
Volker_E
added a project:
Documentation
Apr 6 2022, 3:56 PM
2022-04-06 15:56:38 (UTC+0)
Volker_E
mentioned this in
T293127: [EPIC] Design System Foundation: Design and define design tokens
Volker_E
added a parent task:
T293127: [EPIC] Design System Foundation: Design and define design tokens
Apr 6 2022, 4:01 PM
2022-04-06 16:01:40 (UTC+0)
Sarai-WMDE
mentioned this in
T304566: Update TextInput to meet the Figma designs
Apr 13 2022, 6:51 PM
2022-04-13 18:51:34 (UTC+0)
AnneT
added a project:
Design-System-Team (Design-System-Sprint)
Apr 18 2022, 4:23 PM
2022-04-18 16:23:42 (UTC+0)
AnneT
moved this task from
Committed
to
Ready for Development
on the
Design-System-Team (Design-System-Sprint)
board.
AnneT
moved this task from
Ready for Development
to
In Development
on the
Design-System-Team (Design-System-Sprint)
board.
Apr 18 2022, 5:42 PM
2022-04-18 17:42:56 (UTC+0)
gerritbot
added a comment.
Apr 18 2022, 6:19 PM
2022-04-18 18:19:49 (UTC+0)
Comment Actions
Change 783871 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[design/codex@main] docs: Use design tokens within codex-docs custom theme
gerritbot
added a project:
Patch-For-Review
Apr 18 2022, 6:19 PM
2022-04-18 18:19:50 (UTC+0)
AnneT
updated the task description.
(Show Details)
Apr 18 2022, 6:25 PM
2022-04-18 18:25:55 (UTC+0)
gerritbot
added a comment.
Apr 19 2022, 6:45 PM
2022-04-19 18:45:02 (UTC+0)
Comment Actions
Change 783871
merged
by jenkins-bot:
[design/codex@main] docs: Use design tokens within codex-docs custom theme
AnneT
moved this task from
In Development
to
Design Sign-Off
on the
Design-System-Team (Design-System-Sprint)
board.
Apr 19 2022, 6:49 PM
2022-04-19 18:49:00 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Apr 19 2022, 7:31 PM
2022-04-19 19:31:04 (UTC+0)
Volker_E
renamed this task from
Codex docs theme CSS should use design tokens
to
Codex docs theme CSS should use default theme 'WikimediaUI' design tokens
Apr 29 2022, 8:49 PM
2022-04-29 20:49:50 (UTC+0)
Volker_E
updated the task description.
(Show Details)
gerritbot
added a comment.
Apr 29 2022, 8:51 PM
2022-04-29 20:51:44 (UTC+0)
Comment Actions
Change 787815 had a related patch set uploaded (by VolkerE; author: Anne Tomasevich):
[design/codex@main] docs: Set VitePress text color to `color-base`
gerritbot
added a project:
Patch-For-Review
Apr 29 2022, 8:51 PM
2022-04-29 20:51:45 (UTC+0)
gerritbot
added a comment.
Apr 29 2022, 9:01 PM
2022-04-29 21:01:55 (UTC+0)
Comment Actions
Change 787815
merged
by jenkins-bot:
[design/codex@main] docs: Set VitePress text color to `color-base`
Volker_E
added a parent task:
T304062: docs: Codex doc site visual design/user experience improvements
Apr 29 2022, 9:08 PM
2022-04-29 21:08:12 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Apr 29 2022, 9:30 PM
2022-04-29 21:30:51 (UTC+0)
STH
triaged this task as
High
priority.
May 1 2022, 12:55 PM
2022-05-01 12:55:46 (UTC+0)
STH
changed the task status from
Open
to
In Progress
May 1 2022, 1:23 PM
2022-05-01 13:23:05 (UTC+0)
STH
lowered the priority of this task from
High
to
Medium
STH
edited projects, added
Design-System-Team
; removed
Design-System-Team (Design-System-Sprint)
Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)
STH
moved this task from
Inbox
to
Up Next
on the
Design-System-Team
board.
Catrope
edited projects, added
Design-System-Team (Design-System-Sprint)
; removed
Design-System-Team
May 2 2022, 8:53 PM
2022-05-02 20:53:50 (UTC+0)
Volker_E
subscribed.
Jun 28 2022, 1:54 AM
2022-06-28 01:54:10 (UTC+0)
Comment Actions
This should be active as long as we don't have all essential tokens (size/spacing, typography aka font family, size, …, line height, breakpoints) merged. As long as we have non DS design-decision values in the demos, we should keep this open. It's more like an [EPIC] task IMO.
Volker_E
edited projects, added
Design-System-Team
; removed
Design-System-Team (Design-System-Sprint)
Jun 28 2022, 1:55 AM
2022-06-28 01:55:51 (UTC+0)
DAbad
lowered the priority of this task from
Medium
to
Low
Jul 28 2022, 8:01 PM
2022-07-28 20:01:54 (UTC+0)
gerritbot
added a comment.
Sep 22 2022, 3:41 AM
2022-09-22 03:41:54 (UTC+0)
Comment Actions
Change 833884 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs, tokens: Replace deprecated design tokens
gerritbot
added a project:
Patch-For-Review
Sep 22 2022, 3:41 AM
2022-09-22 03:41:55 (UTC+0)
gerritbot
added a comment.
Sep 28 2022, 1:19 AM
2022-09-28 01:19:59 (UTC+0)
Comment Actions
Change 833884
merged
by jenkins-bot:
[design/codex@main] docs, tokens: Replace deprecated design tokens
Maintenance_bot
removed a project:
Patch-For-Review
Sep 28 2022, 1:29 AM
2022-09-28 01:29:32 (UTC+0)
gerritbot
added a comment.
Sep 30 2022, 7:32 PM
2022-09-30 19:32:44 (UTC+0)
Comment Actions
Change 837181 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs: Replace static `text-decoration` values with Codex tokens
gerritbot
added a project:
Patch-For-Review
Sep 30 2022, 7:32 PM
2022-09-30 19:32:45 (UTC+0)
gerritbot
added a comment.
Sep 30 2022, 10:17 PM
2022-09-30 22:17:48 (UTC+0)
Comment Actions
Change 837181
merged
by jenkins-bot:
[design/codex@main] styles, docs: Replace static `text-decoration` values with Codex tokens
Volker_E
removed a project:
Patch-For-Review
Sep 30 2022, 10:57 PM
2022-09-30 22:57:11 (UTC+0)
ldelench_wmf
mentioned this in
T319246: [SPIKE] Reassess Codex docs site technical implementation
Oct 3 2022, 9:37 PM
2022-10-03 21:37:17 (UTC+0)
gerritbot
added a comment.
Oct 4 2022, 7:16 AM
2022-10-04 07:16:12 (UTC+0)
Comment Actions
Change 838063 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs: Use `border-radius-base` design token on footer pager cards
gerritbot
added a project:
Patch-For-Review
Oct 4 2022, 7:16 AM
2022-10-04 07:16:14 (UTC+0)
gerritbot
added a comment.
Oct 24 2022, 11:42 PM
2022-10-24 23:42:59 (UTC+0)
Comment Actions
Change 838063
merged
by jenkins-bot:
[design/codex@main] docs: Use Card styles (and its design tokens) on footer pager cards
gerritbot
added a comment.
Oct 25 2022, 11:01 PM
2022-10-25 23:01:02 (UTC+0)
Comment Actions
Change 849191 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2
gerritbot
added a comment.
Oct 25 2022, 11:35 PM
2022-10-25 23:35:06 (UTC+0)
Comment Actions
Change 849191
merged
by jenkins-bot:
[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2
gerritbot
added a comment.
Nov 8 2022, 9:56 PM
2022-11-08 21:56:50 (UTC+0)
Comment Actions
Change 854619 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs: Replace calculation with spacing token
gerritbot
added a comment.
Nov 9 2022, 2:08 PM
2022-11-09 14:08:28 (UTC+0)
Comment Actions
Change 854619
merged
by jenkins-bot:
[design/codex@main] docs: Replace calculation with spacing token
gerritbot
added a comment.
Nov 22 2022, 6:58 PM
2022-11-22 18:58:11 (UTC+0)
Comment Actions
Change 859597 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0
Catrope
updated the task description.
(Show Details)
Nov 22 2022, 7:11 PM
2022-11-22 19:11:56 (UTC+0)
gerritbot
added a comment.
Nov 22 2022, 7:23 PM
2022-11-22 19:23:58 (UTC+0)
Comment Actions
Change 859597
merged
by jenkins-bot:
[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0
Volker_E
renamed this task from
Codex docs theme CSS should use default theme 'WikimediaUI' design tokens
to
Codex demo CSS should use default theme 'WikimediaUI' design tokens
Dec 19 2022, 6:16 PM
2022-12-19 18:16:15 (UTC+0)
ldelench_wmf
raised the priority of this task from
Low
to
Medium
Dec 19 2022, 10:45 PM
2022-12-19 22:45:49 (UTC+0)
ldelench_wmf
subscribed.
Comment Actions
Discussed at Dec 12 refinement: this is important, but does not block
T293127
ldelench_wmf
removed a parent task:
T293127: [EPIC] Design System Foundation: Design and define design tokens
Dec 19 2022, 10:46 PM
2022-12-19 22:46:06 (UTC+0)
gerritbot
added a comment.
Dec 23 2022, 7:39 AM
2022-12-23 07:39:04 (UTC+0)
Comment Actions
Change 871022 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] tokens, styles: Introduce design-first `font-size` tokens
gerritbot
added a comment.
Dec 23 2022, 9:15 PM
2022-12-23 21:15:10 (UTC+0)
Comment Actions
Change 871238 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs, tokens: Apply `line-height` tokens everywhere
gerritbot
added a comment.
Jan 5 2023, 10:11 PM
2023-01-05 22:11:32 (UTC+0)
Comment Actions
Change 871238
merged
by jenkins-bot:
[design/codex@main] docs, tokens: Apply `line-height` tokens everywhere
gerritbot
added a comment.
Jan 10 2023, 11:05 PM
2023-01-10 23:05:46 (UTC+0)
Comment Actions
Change 878213 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3
PatchDemoBot
added a comment.
Jan 10 2023, 11:13 PM
2023-01-10 23:13:02 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by ATomasevich (WMF) using patch(es) linked to this task:
gerritbot
added a comment.
Jan 10 2023, 11:44 PM
2023-01-10 23:44:38 (UTC+0)
Comment Actions
Change 878213
merged
by jenkins-bot:
[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3
PatchDemoBot
added a comment.
Jan 12 2023, 7:08 PM
2023-01-12 19:08:27 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by ATomasevich (WMF) using patch(es) linked to this task was
deleted
gerritbot
added a comment.
Jan 23 2023, 9:21 PM
2023-01-23 21:21:06 (UTC+0)
Comment Actions
Change 871022
merged
by jenkins-bot:
[design/codex@main] tokens, styles: Introduce design-first `font-size` tokens
Maintenance_bot
removed a project:
Patch-For-Review
Jan 23 2023, 9:31 PM
2023-01-23 21:31:27 (UTC+0)
gerritbot
added a comment.
Jan 31 2023, 11:42 PM
2023-01-31 23:42:29 (UTC+0)
Comment Actions
Change 869852 had a related patch set uploaded (by Catrope; author: Catrope):
[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0
gerritbot
added a project:
Patch-For-Review
Jan 31 2023, 11:42 PM
2023-01-31 23:42:30 (UTC+0)
gerritbot
added a comment.
Feb 1 2023, 2:16 AM
2023-02-01 02:16:13 (UTC+0)
Comment Actions
Change 885450 had a related patch set uploaded (by Catrope; author: Catrope):
[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0
gerritbot
added a comment.
Feb 1 2023, 4:12 AM
2023-02-01 04:12:57 (UTC+0)
Comment Actions
Change 885450
merged
by jenkins-bot:
[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0
gerritbot
added a comment.
Feb 11 2023, 4:34 PM
2023-02-11 16:34:54 (UTC+0)
Comment Actions
Change 888290 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs: Refine visual hierarchy and use Codex tokens
Volker_E
added a comment.
Feb 11 2023, 4:42 PM
2023-02-11 16:42:36 (UTC+0)
Comment Actions
Above patch is the last one from my perspective for this task. We can open up new tasks (in response to for example VitePress upstream changes).
Volker_E
edited projects, added
Design-System-Team (Design-System-Sprint)
; removed
Design-System-Team
Feb 11 2023, 4:42 PM
2023-02-11 16:42:55 (UTC+0)
Restricted Application
raised the priority of this task from
Medium
to
High
View Herald Transcript
Feb 11 2023, 4:42 PM
2023-02-11 16:42:55 (UTC+0)
gerritbot
added a comment.
Feb 13 2023, 11:19 PM
2023-02-13 23:19:21 (UTC+0)
Comment Actions
Change 888290
merged
by jenkins-bot:
[design/codex@main] docs: Refine visual hierarchy and use Codex tokens
gerritbot
added a comment.
Feb 14 2023, 8:02 PM
2023-02-14 20:02:53 (UTC+0)
Comment Actions
Change 889216 had a related patch set uploaded (by VolkerE; author: VolkerE):
[design/codex@main] docs: Refine visual hierarchy and use design-first heading styles
gerritbot
added a comment.
Feb 14 2023, 8:28 PM
2023-02-14 20:28:40 (UTC+0)
Comment Actions
Change 889216
merged
by jenkins-bot:
[design/codex@main] docs: Refine visual hierarchy and use design-first heading styles
gerritbot
added a comment.
Feb 14 2023, 9:23 PM
2023-02-14 21:23:59 (UTC+0)
Comment Actions
Change 889230 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0
PatchDemoBot
added a comment.
Feb 14 2023, 9:25 PM
2023-02-14 21:25:57 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by ATomasevich (WMF) using patch(es) linked to this task:
Volker_E
claimed this task.
Feb 14 2023, 9:50 PM
2023-02-14 21:50:05 (UTC+0)
Volker_E
moved this task from
Design Sign-Off
to
Pending Release
on the
Design-System-Team (Design-System-Sprint)
board.
Volker_E
removed a project:
Patch-For-Review
Volker_E
closed this task as
Resolved
Feb 14 2023, 9:57 PM
2023-02-14 21:57:49 (UTC+0)
Comment Actions
Skipping design and QTE sign-off for this code-only task. Design sign off for other bits is happening in
T325055
VitePress custom.css
is now only using design tokens.
gerritbot
added a comment.
Feb 14 2023, 9:58 PM
2023-02-14 21:58:58 (UTC+0)
Comment Actions
Change 889230
merged
by jenkins-bot:
[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0
PatchDemoBot
added a comment.
May 10 2023, 9:08 PM
2023-05-10 21:08:53 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by ATomasevich (WMF) using patch(es) linked to this task was
deleted
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits