⚓ T310665 Impact module: summary panel

⚓ T310665 Impact module: summary panel
Page Menu
Phabricator
Create Task
Maniphest
T310665
Impact module: summary panel
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Sgs
Authored By
KStoller-WMF
Jun 15 2022, 3:39 AM
2022-06-15 03:39:56 (UTC+0)
Tags
Growth-Positive-Reinforcement
(Backlog)
Growth-Team (Sprint 0 (Growth Team))
(QA)
Patch-For-Review
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
GrowthExperiments-ImpactModule
(NewImpact Release (Completed/QA))
Referenced Files
F35829039: image.png
Dec 2 2022, 9:25 PM
2022-12-02 21:25:01 (UTC+0)
F35823203: Screen Shot 2022-11-28 at 1.04.24 PM.png
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823195: Screen Shot 2022-11-28 at 12.45.58 PM.png
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823184: Screen Shot 2022-11-28 at 12.47.13 PM.png
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823260: IMG_2736.PNG
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823263: IMG_2737.PNG
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823247: Screen Shot 2022-11-28 at 12.40.14 PM.png
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
F35823255: Screen Shot 2022-11-28 at 1.39.00 PM.png
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
View All 14 Files
Subscribers
Aklapper
Etonkovidova
KieranMcCann
kostajh
KStoller-WMF
RHo
Sgs
Description
Description
A new section at the top of the impact module with two key pieces of information, made up of block scorecards (
T310661
Proposed key pieces of information are:
Total edits - with link to the Special:Contributions page for the user
Thanks Received count - with link to Special:Log?type=thanks filtered by the user
Tooltip to explain Thanks:
Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too.
Initial design
Updated design with streak data
Figma Design
QQQ translator instructions
Acceptance Criteria
Given I'm viewing the Impact module,
When I view the summary panel,
Then I can see my "Total edits" count and "Thanks received" count
Given I'm viewing the Impact module,
When click or tap on the info icon next to my Thanks count,
Then I can see a helpful explanation:
More information
Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too.
Completion checklist
Functionality
The patches have been code reviewed and merged
The task passes its acceptance criteria
Engineering
There are existing and passing unit/integration tests
Tests for every involved patch should pass
Coverage for every involved project should have improved or stayed the same
Design & QA
If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
Must be reviewed and approved by Quality Assurance.
Documentation
Related and updated documentation done where necessary
Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc)
Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on
Extension:GrowthExperiments
or
Extension:GrowthExperiments/Technical documentation
pages.
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
User impact: use config skin instead of homepagemobile to adapt mobile styles
mediawiki/extensions/GrowthExperiments
master
+21
-17
New impact: delete wrong info icon label
mediawiki/extensions/GrowthExperiments
master
+0
-2
User impact: add infoboxes to thanks and streak scorecards
mediawiki/extensions/GrowthExperiments
master
+155
-23
User impact: adapt content margin/padding when displayed in the mobile overlay
mediawiki/extensions/GrowthExperiments
master
+66
-14
Mentee overview: move info popover components to vue-components
mediawiki/extensions/GrowthExperiments
master
+166
-124
User impact: display best streak data in scorecards
mediawiki/extensions/GrowthExperiments
master
+249
-199
User impact: add edit count and thanks score cards
mediawiki/extensions/GrowthExperiments
master
+457
-20
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Open
KStoller-WMF
T248330
[EPIC] Growth: Positive reinforcement
Resolved
KStoller-WMF
T222310
[EPIC] Positive reinforcement: New Impact Module
Resolved
Sgs
T310665
Impact module: summary panel
Resolved
Sgs
T310661
Impact module: scorecards
Resolved
Sgs
T321963
NewImpact module: Implement unactivated state code from Impact.php
Resolved
Sgs
T322850
Add thanks and longest streak scorecards to the unactivated state
Resolved
Sgs
T329157
NewImpact: Make mobile CTA button use progressive primary blue
Mentioned In
T327497: Standardize info icon size and RTL alternative graphic
T325325: Impact Module: "i" icon alignment
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
T310666: Impact Module: Recent Editing Activity
T310661: Impact module: scorecards
Mentioned Here
T327497: Standardize info icon size and RTL alternative graphic
T311382: Update 'info' icon in OOUI and Codex
T178568: [Investigate] Should some OOUI-icons be different on ar-wiki?
T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay
T258020: Variant C: Info icon in suggested edits module
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
T318542: Impact module: Create mobile summary view
T310661: Impact module: scorecards
T310742: Editing tasks results in "You cannot add more than 0 objects to the relationship" error
Event Timeline
There are a very large number of changes, so older changes are hidden.
Show Older Changes
Restricted Application
added a project:
Growth-Team
View Herald Transcript
Jul 3 2022, 7:10 PM
2022-07-03 19:10:43 (UTC+0)
kostajh
updated the task description.
(Show Details)
Jul 19 2022, 4:25 PM
2022-07-19 16:25:43 (UTC+0)
kostajh
edited projects, added
Growth-Team (Sprint 0 (Growth Team))
; removed
Growth-Team
Comment Actions
@KStoller-WMF
I think this is actionable, I will create a separate task for the "Edit quality" component, which can be built later when its specifications are finalized.
kostajh
moved this task from
Incoming
to
Ready for Development
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Jul 19 2022, 4:26 PM
2022-07-19 16:26:21 (UTC+0)
kostajh
mentioned this in
T310661: Impact module: scorecards
Jul 19 2022, 4:29 PM
2022-07-19 16:29:21 (UTC+0)
kostajh
added a subtask:
T310661: Impact module: scorecards
Jul 20 2022, 10:06 AM
2022-07-20 10:06:10 (UTC+0)
kostajh
changed the status of subtask
T310661: Impact module: scorecards
from
Stalled
to
Open
KStoller-WMF
triaged this task as
Medium
priority.
Jul 22 2022, 10:06 PM
2022-07-22 22:06:27 (UTC+0)
KieranMcCann
updated the task description.
(Show Details)
Sep 8 2022, 9:47 AM
2022-09-08 09:47:08 (UTC+0)
KStoller-WMF
updated the task description.
(Show Details)
Sep 16 2022, 11:25 PM
2022-09-16 23:25:07 (UTC+0)
KStoller-WMF
updated the task description.
(Show Details)
Sep 18 2022, 2:16 PM
2022-09-18 14:16:45 (UTC+0)
gerritbot
added a comment.
Sep 21 2022, 7:00 PM
2022-09-21 19:00:56 (UTC+0)
Comment Actions
Change 819113 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: add edit count and thanks score cards
gerritbot
added a project:
Patch-For-Review
Sep 21 2022, 7:00 PM
2022-09-21 19:00:57 (UTC+0)
Sgs
changed the status of subtask
T310661: Impact module: scorecards
from
Open
to
In Progress
Sep 22 2022, 10:48 PM
2022-09-22 22:48:42 (UTC+0)
gerritbot
added a comment.
Sep 28 2022, 7:40 PM
2022-09-28 19:40:27 (UTC+0)
Comment Actions
Change 819113
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: add edit count and thanks score cards
ReleaseTaggerBot
added a project:
MW-1.40-notes (1.40.0-wmf.4; 2022-10-03)
Sep 28 2022, 8:00 PM
2022-09-28 20:00:34 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Sep 28 2022, 8:31 PM
2022-09-28 20:31:38 (UTC+0)
Sgs
claimed this task.
Sep 29 2022, 11:53 AM
2022-09-29 11:53:15 (UTC+0)
Sgs
moved this task from
Ready for Development
to
In Progress
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Sgs
added a subscriber:
KieranMcCann
Sep 29 2022, 12:51 PM
2022-09-29 12:51:59 (UTC+0)
Comment Actions
We're missing the Codex replacement for the tooltip component that shows information when clicking on the info icons. We could use the Mentor dashboard dropdown style component (mind that that component does not have horizontal overflow control so we might need to restrict its width and unfolding side for some time so it works on mobile). We could also try to use mobile front end dialogs although they are a bit obtrusive. Or we could create a hidden collapsible section under the score cards. cc
@KieranMcCann
@kostajh
KieranMcCann
added a comment.
Sep 29 2022, 5:29 PM
2022-09-29 17:29:53 (UTC+0)
Comment Actions
@Sgs
could you send me a screenshot of what you mean by ‘Mentor dashboard dropdown style component’ as I’m not entirely clear on what that is. Thanks
Sgs
added a comment.
Sep 30 2022, 1:33 PM
2022-09-30 13:33:33 (UTC+0)
Comment Actions
In
T310665#8273436
@KieranMcCann
wrote:
@Sgs
could you send me a screenshot of what you mean by ‘Mentor dashboard dropdown style component’ as I’m not entirely clear on what that is. Thanks
You can enroll as a mentor and claim some users as mentees in beta and test wikis using
Special:EnrollAsMentor
. The mentor dashboard is not developed for mobile so we did not work on the possible horizontal overflow problems :/
An alternative that I can think of is a contextual collapsible area below the scorecards as opposite of a floating overlay. Something similar to the red tooltip in the screenshot below:
Sgs
changed the status of subtask
T310661: Impact module: scorecards
from
In Progress
to
Open
Sep 30 2022, 1:47 PM
2022-09-30 13:47:12 (UTC+0)
KieranMcCann
added a comment.
Oct 11 2022, 4:29 PM
2022-10-11 16:29:33 (UTC+0)
Comment Actions
@Sgs
Thanks for sending those. My preference would be to use the ‘mentor dashboard dropdown style’ you mentioned.
KieranMcCann
added a comment.
Oct 11 2022, 4:30 PM
2022-10-11 16:30:06 (UTC+0)
Comment Actions
Noting here that after discussion on
T310666
it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel.
Figma designs
have been updated to reflect this.
Sgs
updated the task description.
(Show Details)
Edited
Oct 12 2022, 9:19 AM
2022-10-12 09:19:23 (UTC+0)
Comment Actions
In
T310665#8308600
@KieranMcCann
wrote:
@Sgs
Thanks for sending those. My preference would be to use the ‘mentor dashboard dropdown style’ you mentioned.
Ack, we will use that one until Codex provides a fine replacement.
In
T310665#8308613
@KieranMcCann
wrote:
Noting here that after discussion on
T310666
it has been proposed that the ‘last edited’ and ‘best streak’ data points should be styled as scorecards and moved into the summary panel.
Figma designs
have been updated to reflect this.
Ack, I've updated the task description with the newer screenshot.
How would this change affect the mobile summary view in
T318542: Impact module: Create mobile summary view
Should we only display the trend chart?
@RHo
Sgs
added a subscriber:
RHo
Oct 12 2022, 9:22 AM
2022-10-12 09:22:38 (UTC+0)
gerritbot
added a comment.
Oct 14 2022, 4:21 PM
2022-10-14 16:21:44 (UTC+0)
Comment Actions
Change 842848 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: display best streak data in scorecards
gerritbot
added a project:
Patch-For-Review
Oct 14 2022, 4:21 PM
2022-10-14 16:21:45 (UTC+0)
Sgs
changed the task status from
Open
to
In Progress
Oct 14 2022, 6:36 PM
2022-10-14 18:36:35 (UTC+0)
Sgs
moved this task from
In Progress
to
Code Review
on the
Growth-Team (Sprint 0 (Growth Team))
board.
gerritbot
added a comment.
Oct 18 2022, 10:18 AM
2022-10-18 10:18:57 (UTC+0)
Comment Actions
Change 842848
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: display best streak data in scorecards
Maintenance_bot
removed a project:
Patch-For-Review
Oct 18 2022, 10:31 AM
2022-10-18 10:31:44 (UTC+0)
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.7; 2022-10-24)
; removed
MW-1.40-notes (1.40.0-wmf.4; 2022-10-03)
Oct 18 2022, 11:00 AM
2022-10-18 11:00:59 (UTC+0)
kostajh
changed the task status from
In Progress
to
Open
Oct 18 2022, 3:11 PM
2022-10-18 15:11:19 (UTC+0)
kostajh
moved this task from
Code Review
to
QA
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Sgs
changed the task status from
Open
to
In Progress
Oct 18 2022, 6:10 PM
2022-10-18 18:10:12 (UTC+0)
Sgs
moved this task from
QA
to
Code Review
on the
Growth-Team (Sprint 0 (Growth Team))
board.
gerritbot
added a comment.
Oct 19 2022, 12:02 PM
2022-10-19 12:02:14 (UTC+0)
Comment Actions
Change 844462 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Mentee overview: move info popover components to vue-components
gerritbot
added a project:
Patch-For-Review
Oct 19 2022, 12:02 PM
2022-10-19 12:02:14 (UTC+0)
Comment Actions
Change 844463 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: add infoboxes to thanks and streak scorecards
gerritbot
added a comment.
Oct 19 2022, 12:59 PM
2022-10-19 12:59:03 (UTC+0)
Comment Actions
Change 844467 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: adapt content margin/padding when displayed in the mobile overlay
gerritbot
added a comment.
Oct 20 2022, 6:56 PM
2022-10-20 18:56:48 (UTC+0)
Comment Actions
Change 844462
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentee overview: move info popover components to vue-components
kostajh
mentioned this in
T310666: Impact Module: Recent Editing Activity
Oct 20 2022, 7:37 PM
2022-10-20 19:37:42 (UTC+0)
gerritbot
added a comment.
Oct 20 2022, 7:44 PM
2022-10-20 19:44:01 (UTC+0)
Comment Actions
Change 844467
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: adapt content margin/padding when displayed in the mobile overlay
gerritbot
added a comment.
Oct 21 2022, 10:29 AM
2022-10-21 10:29:39 (UTC+0)
Comment Actions
Change 845482 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: use config skin instead of homepagemobile to adapt mobile styles
gerritbot
added a comment.
Oct 26 2022, 7:37 PM
2022-10-26 19:37:12 (UTC+0)
Comment Actions
Change 844463
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: add infoboxes to thanks and streak scorecards
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
; removed
MW-1.40-notes (1.40.0-wmf.7; 2022-10-24)
Oct 26 2022, 8:01 PM
2022-10-26 20:01:00 (UTC+0)
gerritbot
added a comment.
Oct 27 2022, 8:43 AM
2022-10-27 08:43:40 (UTC+0)
Comment Actions
Change 850033 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] New impact: delete wrong info icon label
gerritbot
added a comment.
Oct 27 2022, 9:06 AM
2022-10-27 09:06:59 (UTC+0)
Comment Actions
Change 850033
merged
by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] New impact: delete wrong info icon label
Sgs
changed the task status from
In Progress
to
Open
Oct 27 2022, 10:45 AM
2022-10-27 10:45:06 (UTC+0)
Sgs
moved this task from
Code Review
to
QA
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Sgs
attached a referenced file:
F35534656: image.png
(Show Details)
Nov 9 2022, 11:46 AM
2022-11-09 11:46:34 (UTC+0)
Sgs
attached a referenced file:
F35545126: Screenshot 2022-10-03 at 10.35.45.png
(Show Details)
kostajh
added a project:
GrowthExperiments-ImpactModule
Nov 21 2022, 4:48 PM
2022-11-21 16:48:56 (UTC+0)
Etonkovidova
moved this task from
QA
to
Design Review
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Nov 28 2022, 9:46 PM
2022-11-28 21:46:38 (UTC+0)
Etonkovidova
subscribed.
Comment Actions
@Sgs
- is the following spec will be implemented in another task?
Thanks Received count - with link to Special:Log?type=thanks filtered by the user
For
@RHo
quick review - the functionality/UI seem to be fine. The screenshots are for illustration (no issues were found):
Mobile
Below is my note on the info buttons in RTL. If no follow-up actions are needed on this task, you may move it to
Test in Production.
Note:
just double-checking if it's intended - two types of info icons are present in RTL
The bulb info icon is present in
arwiki
production now too - in the Add image dialog and on the MentorDashboard.
But the presence of two types info icons on Homepage makes it more noticeable. Also, the behavior - one icon has a closing button, another one disappears when the focus is shifted, and the third one has the Cancel button.
kostajh
mentioned this in
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
Nov 30 2022, 10:27 AM
2022-11-30 10:27:17 (UTC+0)
Comment Actions
In
T310665#8426469
@Etonkovidova
wrote:
@Sgs
- is the following spec will be implemented in another task?
Thanks Received count - with link to Special:Log?type=thanks filtered by the user
I made
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
for that.
Etonkovidova
added a comment.
Dec 2 2022, 7:18 PM
2022-12-02 19:18:58 (UTC+0)
Comment Actions
In
T310665#8431179
@kostajh
wrote:
In
T310665#8426469
@Etonkovidova
wrote:
@Sgs
- is the following spec will be implemented in another task?
Thanks Received count - with link to Special:Log?type=thanks filtered by the user
I made
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
for that.
T324087
- Verified in
wmf.12
Leaving in
Design Review
to get feedback on
(re different info icons on
arwiki
).
RHo
moved this task from
Design Review
to
Blocked / Needs work
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Dec 2 2022, 9:25 PM
2022-12-02 21:25:01 (UTC+0)
Comment Actions
In
T310665#8439851
@Etonkovidova
wrote:
In
T310665#8431179
@kostajh
wrote:
In
T310665#8426469
@Etonkovidova
wrote:
@Sgs
- is the following spec will be implemented in another task?
Thanks Received count - with link to Special:Log?type=thanks filtered by the user
I made
T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user
for that.
T324087
- Verified in
wmf.12
Leaving in
Design Review
to get feedback on
(re different info icons on
arwiki
).
Thanks
@Etonkovidova
- this is indeed not expected, it should always be the "i" info icon in arwiki as well.
Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in
OOUI
):
I am putting back into in-progress, +
@KieranMcCann
for visibility and re-review of revisions while I'm OoO. Thanks again!
kostajh
moved this task from
Triage
to
NewImpact Release (Completed/QA)
on the
GrowthExperiments-ImpactModule
board.
Dec 5 2022, 8:43 AM
2022-12-05 08:43:08 (UTC+0)
Sgs
added a comment.
Edited
Dec 15 2022, 12:36 PM
2022-12-15 12:36:53 (UTC+0)
Comment Actions
In
T310665#8440081
@RHo
wrote:
Thanks
@Etonkovidova
- this is indeed not expected, it should always be the "i" info icon in arwiki as well.
I don't think that's the correct expectation, per discussion in
T178568: [Investigate] Should some OOUI-icons be different on ar-wiki?
my understanding is the expectation for Arabic language is to see a light bulb icon every where. The reason for the discrepancy is we're using a non-standard non-OOUI icon called
info-unpadded
per alignment requirements in
T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay
Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in
OOUI
):
In the new impact module built with Vue and Codex we're using
Codex icons
which render at 20x20px and so is the info icon from the suggested edits module per requirements in
T258020#6439128
My proposal would be to drop "info-unpadded" custom icon in favor of standard "info" which will always display as light bulb in Arabic and do any alignment adjustments in CSS.
Sgs
removed
Sgs
as the assignee of this task.
Dec 15 2022, 12:37 PM
2022-12-15 12:37:19 (UTC+0)
Sgs
moved this task from
Blocked / Needs work
to
Needs Design/Design Doing
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Sgs
subscribed.
KStoller-WMF
closed subtask
T310661: Impact module: scorecards
as
Resolved
Dec 15 2022, 7:54 PM
2022-12-15 19:54:40 (UTC+0)
KStoller-WMF
mentioned this in
T325325: Impact Module: "i" icon alignment
Dec 16 2022, 12:32 AM
2022-12-16 00:32:22 (UTC+0)
RHo
moved this task from
Needs Design/Design Doing
to
Ready for Development
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Jan 6 2023, 2:57 PM
2023-01-06 14:57:06 (UTC+0)
Comment Actions
In
T310665#8470610
@Sgs
wrote:
In
T310665#8440081
@RHo
wrote:
Thanks
@Etonkovidova
- this is indeed not expected, it should always be the "i" info icon in arwiki as well.
I don't think that's the correct expectation, per discussion in
T178568: [Investigate] Should some OOUI-icons be different on ar-wiki?
my understanding is the expectation for Arabic language is to see a light bulb icon every where. The reason for the discrepancy is we're using a non-standard non-OOUI icon called
info-unpadded
per alignment requirements in
T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay
Secondly, please note that the info icons here should only be 16x16px sized per the spec (as it is expected to be using the the info icons and the popup button widget in
OOUI
):
In the new impact module built with Vue and Codex we're using
Codex icons
which render at 20x20px and so is the info icon from the suggested edits module per requirements in
T258020#6439128
There was a task recent to update the smaller info that is used in these tooltip/popovers so that it shows at the smaller size
. If we are proceeding with the lightbulb icon for Arabic, it should be similarly made smaller - is this a relatively easy fix?
My proposal would be to drop "info-unpadded" custom icon in favor of standard "info" which will always display as light bulb in Arabic and do any alignment adjustments in CSS.
Thanks, works for me.
gerritbot
added a comment.
Jan 9 2023, 12:54 PM
2023-01-09 12:54:21 (UTC+0)
Comment Actions
Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded
kostajh
assigned this task to
Sgs
Jan 10 2023, 7:59 PM
2023-01-10 19:59:38 (UTC+0)
kostajh
moved this task from
Ready for Development
to
In Progress
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Comment Actions
In
T310665#8508967
@gerritbot
wrote:
Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded
@Sgs
assigning to you, per the patch you've submitted.
Sgs
mentioned this in
T327497: Standardize info icon size and RTL alternative graphic
Jan 20 2023, 1:11 PM
2023-01-20 13:11:15 (UTC+0)
Sgs
added a comment.
Jan 20 2023, 1:13 PM
2023-01-20 13:13:27 (UTC+0)
Comment Actions
In
T310665#8514176
@kostajh
wrote:
In
T310665#8508967
@gerritbot
wrote:
Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded
@Sgs
assigning to you, per the patch you've submitted.
I have filed
T327497: Standardize info icon size and RTL alternative graphic
to tackle the icon discrepancies aside since there are some design questions I'd like to clarify. And also this ticket can go to QA/Test in production, if
@Etonkovidova
agrees.
Sgs
moved this task from
In Progress
to
QA
on the
Growth-Team (Sprint 0 (Growth Team))
board.
Jan 20 2023, 1:13 PM
2023-01-20 13:13:40 (UTC+0)
KStoller-WMF
closed this task as
Resolved
Feb 10 2023, 12:37 AM
2023-02-10 00:37:56 (UTC+0)
Urbanecm_WMF
removed a subscriber:
MShilova_WMF
Jul 31 2023, 6:03 PM
2023-07-31 18:03:56 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits