⚓ T313409 Hide article toolbar/tab-bar if there is only one item/tab

⚓ T313409 Hide article toolbar/tab-bar if there is only one item/tab
Page Menu
Phabricator
Create Task
Maniphest
T313409
Hide article toolbar/tab-bar if there is only one item/tab
Closed, Resolved
Public
3 Estimated Story Points
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
ovasileva
Authored By
alexhollender_WMF
Jul 20 2022, 1:33 PM
2022-07-20 13:33:12 (UTC+0)
Tags
Vector 2022
(Page Tools)
MediaWiki-Core-Skin-Architecture (Menus 2.0)
(Backlog)
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
(Ready for Signoff)
MW-1.39-notes (1.39.0-wmf.28; 2022-09-05)
Referenced Files
F35513608: Screen Shot 2022-09-08 at 8.35.58 AM.png
Sep 8 2022, 3:36 PM
2022-09-08 15:36:37 (UTC+0)
F35505970: Screen Shot 2022-09-01 at 1.41.43 PM.png
Sep 1 2022, 8:42 PM
2022-09-01 20:42:27 (UTC+0)
F35505968: Screen Shot 2022-09-01 at 1.40.59 PM.png
Sep 1 2022, 8:42 PM
2022-09-01 20:42:27 (UTC+0)
F35498717: capture.png
Aug 30 2022, 9:29 PM
2022-08-30 21:29:22 (UTC+0)
F35498715: Screenshot
Aug 30 2022, 9:29 PM
2022-08-30 21:29:22 (UTC+0)
F35326853: image.png
Jul 20 2022, 4:48 PM
2022-07-20 16:48:59 (UTC+0)
F35326833: Screenshot_2022-07-20-09-26-55-82_3aea4af51f236e4932235fdada7d1643.jpg
Jul 20 2022, 4:27 PM
2022-07-20 16:27:59 (UTC+0)
F35323172: image.png
Jul 20 2022, 1:34 PM
2022-07-20 13:34:24 (UTC+0)
View All 10 Files
Subscribers
Aklapper
alexhollender_WMF
cjming
Edtadros
Izno
Jdlrobson
Jdrewniak
View All 12 Subscribers
Description
NOTE:
if you have feedback on this feature you are invited to share it on
. This task should only be used for discussing implementation.
NOTE:
The tab can be restored with the following gadget/user script:
var sp = mw.config.get('wgCanonicalSpecialPageName'); if ( sp ) { mw.util.addPortletLink('p-associated-pages', mw.util.getUrl(sp), 'Special page' ); }
Description
For pages where there is only one item/tab in the article toolbar/tab-bar we should hide the article toolbar/tab-bar. Example:
current
hidden
Open questions
Some gadgets show in that toolbar/tab-bar area on certain special pages (e.g. Twinkle). How do we want to handle this?
Show the toolbar/tab-bar?
Work with gadget authors to re-locate the position of the gadget on special pages?
QA steps
Make sure no "Special page" tab shows on
Make sure a "Special page" tab shows on legacy Vector (
Visit
and confirm 3 tabs are shown.
For all the above page, inspect the DOM and check that these tabs are inside an element with ID p-associated-pages like so:
Check
and make sure the arrow tabs, page, discussion, image and index tabs are present
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
[POC] Add tab to recent changes for resetting form
mediawiki/core
master
+15
-0
[POC] Special page tab is restored to all special pages
mediawiki/core
master
+7
-1
Enable related tabs on Vector
mediawiki/skins/Vector
master
+39
-1
SkinTemplate: Make associatedPages menu backwards compatible with namespaces
mediawiki/core
master
+18
-0
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
ovasileva
T317884
[EPIC] Vector 2022 post-deployment work
Declined
ovasileva
T317632
[EPIC] Visual refinements pt2
Resolved
ovasileva
T313409
Hide article toolbar/tab-bar if there is only one item/tab
Resolved
Mabualruz
T313349
Allow special pages to register navigation links in skins
Mentioned In
T347907: Drop support for addPortletLink with #p-namespaces in Vector 2022 skin
T316908: [Potentially breaking change in Vector 2022] #p-namespaces element being replaced by #p-associated-pages
Mentioned Here
T163098: Fix the Watchlist visual layout
T316169: Left tab bar wraps each item into a new line on all Wikisource
T313349: Allow special pages to register navigation links in skins
Event Timeline
There are a very large number of changes, so older changes are hidden.
Show Older Changes
alexhollender_WMF
added a parent task:
T303549: Move titlebar above toolbar
Jul 20 2022, 1:33 PM
2022-07-20 13:33:30 (UTC+0)
alexhollender_WMF
updated the task description.
(Show Details)
ovasileva
triaged this task as
Medium
priority.
Jul 20 2022, 1:37 PM
2022-07-20 13:37:52 (UTC+0)
Izno
subscribed.
Jul 20 2022, 4:27 PM
2022-07-20 16:27:59 (UTC+0)
Comment Actions
Please provide or indicate how you propose to handle gadgets like Twinkle which have a home in that space on special pages.
alexhollender_WMF
updated the task description.
(Show Details)
Jul 20 2022, 4:42 PM
2022-07-20 16:42:52 (UTC+0)
Comment Actions
In
T313409#8091755
@Izno
wrote:
Please provide or indicate how you propose to handle gadgets like Twinkle which have a home in that space on special pages.
{F35326846}
thanks for raising this
@Izno
. to clarify your point I've highlighted the tab-bar and the twinkle gadget.
I've updated the task description to include: if someone has a gadget installed that shows in that space the tab-bar should still appear. one of the developers on our team will be able to speak to possible approaches here.
alexhollender_WMF
updated the task description.
(Show Details)
Jul 20 2022, 4:48 PM
2022-07-20 16:48:59 (UTC+0)
Jdlrobson
added a subtask:
T313349: Allow special pages to register navigation links in skins
Jul 20 2022, 4:50 PM
2022-07-20 16:50:50 (UTC+0)
Comment Actions
This work should be blocked on
T313349
as presumably, we want this to be limited to the new Vector and not older skins.
Jdlrobson
edited projects, added
Web-Team-Backlog-Archived
; removed
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
Jul 20 2022, 4:51 PM
2022-07-20 16:51:04 (UTC+0)
Jdlrobson
moved this task from
Incoming
to
Not ready to estimate
on the
Web-Team-Backlog-Archived
board.
Jul 21 2022, 5:11 PM
2022-07-21 17:11:54 (UTC+0)
Jdlrobson
moved this task from
Incoming
to
Page Tools
on the
Vector 2022
board.
Jul 21 2022, 10:06 PM
2022-07-21 22:06:35 (UTC+0)
Jdlrobson
added a project:
MediaWiki-Core-Skin-Architecture
ovasileva
moved this task from
Not ready to estimate
to
Current Fiscal Year
on the
Web-Team-Backlog-Archived
board.
Jul 25 2022, 9:18 AM
2022-07-25 09:18:41 (UTC+0)
Jdlrobson
edited projects, added
MediaWiki-Core-Skin-Architecture (Menus 2.0)
; removed
MediaWiki-Core-Skin-Architecture
Aug 15 2022, 10:44 AM
2022-08-15 10:44:12 (UTC+0)
Jdlrobson
edited projects, added
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
; removed
Web-Team-Backlog-Archived
Aug 18 2022, 6:33 AM
2022-08-18 06:33:27 (UTC+0)
Comment Actions
We are ready to do this now if we need to!
gerritbot
added a comment.
Aug 18 2022, 6:33 AM
2022-08-18 06:33:34 (UTC+0)
Comment Actions
Change 816209 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Enable related tabs on Vector
gerritbot
added a project:
Patch-For-Review
Aug 18 2022, 6:33 AM
2022-08-18 06:33:35 (UTC+0)
Jdlrobson
moved this task from
Needs Analysis
to
Upcoming
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 18 2022, 6:34 AM
2022-08-18 06:34:31 (UTC+0)
Jdlrobson
closed subtask
T313349: Allow special pages to register navigation links in skins
as
Resolved
Aug 18 2022, 9:32 PM
2022-08-18 21:32:26 (UTC+0)
Jdlrobson
claimed this task.
Aug 23 2022, 3:44 PM
2022-08-23 15:44:04 (UTC+0)
ovasileva
set the point value for this task to
Aug 23 2022, 5:50 PM
2022-08-23 17:50:32 (UTC+0)
ovasileva
moved this task from
Upcoming
to
Ready for Development
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Jdlrobson
moved this task from
Ready for Development
to
Doing
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 23 2022, 5:52 PM
2022-08-23 17:52:17 (UTC+0)
Comment Actions
Estimated today. I'll provide some feedback to
@Izno
regarding his comment in
T313409#8091755
- these should continue to work. The menu will still exist but will have zero items. I will confirm this by end of week with some code.
PatchDemoBot
added a comment.
Aug 23 2022, 9:12 PM
2022-08-23 21:12:18 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by Jdlrobson using patch(es) linked to this task:
PatchDemoBot
added a comment.
Aug 23 2022, 9:42 PM
2022-08-23 21:42:05 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by Jdlrobson using patch(es) linked to this task:
Jdlrobson
added a comment.
Aug 23 2022, 9:47 PM
2022-08-23 21:47:48 (UTC+0)
Comment Actions
Visit
and you'll see the special tab is gone.
A new link can be added via
mw.util.addPortletLink('p-associatedPages', '#', 'new link')
I realize this is a change, as it means anyone referencing p-namespace would now need to reference p-associatedPages instead. It looks like that would impact around 466 different scripts, which is pretty low, but non-zero:
I updated the patch to retain compatibility and log warnings to gadgets. I suggest we remove this within the next few months:
The following code works just as before:
mw.util.addPortletLink('p-namespaces', '#', 'new link')
Sound like a plan?
Jdlrobson
moved this task from
Doing
to
Code Review
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 23 2022, 9:48 PM
2022-08-23 21:48:02 (UTC+0)
Jdlrobson
moved this task from
Code Review
to
Doing
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 24 2022, 2:48 PM
2022-08-24 14:48:44 (UTC+0)
Jdlrobson
added a comment.
Aug 26 2022, 6:40 PM
2022-08-26 18:40:56 (UTC+0)
Comment Actions
Still working this out. Specifically need to work out the behaviour with
T316169
and other existing namespaces e.g. the translate tab in Extension:Translate and
, TimedMediaHandler (for TimedText files), and
gerritbot
added a comment.
Aug 30 2022, 3:48 PM
2022-08-30 15:48:31 (UTC+0)
Comment Actions
Change 828047 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] SkinTemplate: Make associatedPages menu backwards compatible with namespaces
Jdlrobson
moved this task from
Doing
to
Code Review
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Aug 30 2022, 3:52 PM
2022-08-30 15:52:02 (UTC+0)
Krinkle
subscribed.
Edited
Aug 30 2022, 9:29 PM
2022-08-30 21:29:22 (UTC+0)
Comment Actions
In
T313409#8091755
@Izno
wrote:
Please provide or indicate how you propose to handle gadgets like Twinkle which have a home in that space on special pages.
See also:
Perf menu
CVN overlay
Jdlrobson
added a comment.
Aug 30 2022, 9:43 PM
2022-08-30 21:43:34 (UTC+0)
Comment Actions
I've just tested htem and
perf menu
and
CVN overlay
both work perfectly fine with the proposed changes.
Jdlrobson
removed
Jdlrobson
as the assignee of this task.
Aug 31 2022, 11:28 PM
2022-08-31 23:28:19 (UTC+0)
cjming
claimed this task.
Sep 1 2022, 5:14 PM
2022-09-01 17:14:10 (UTC+0)
gerritbot
added a comment.
Sep 1 2022, 8:14 PM
2022-09-01 20:14:22 (UTC+0)
Comment Actions
Change 828047
merged
by jenkins-bot:
[mediawiki/core@master] SkinTemplate: Make associatedPages menu backwards compatible with namespaces
gerritbot
added a comment.
Sep 1 2022, 8:36 PM
2022-09-01 20:36:15 (UTC+0)
Comment Actions
Change 816209
merged
by jenkins-bot:
[mediawiki/skins/Vector@master] Enable related tabs on Vector
cjming
reassigned this task from
cjming
to
Edtadros
Sep 1 2022, 8:37 PM
2022-09-01 20:37:12 (UTC+0)
cjming
moved this task from
Code Review
to
QA
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
cjming
subscribed.
Jdlrobson
updated the task description.
(Show Details)
Sep 1 2022, 8:42 PM
2022-09-01 20:42:27 (UTC+0)
Jdlrobson
updated the task description.
(Show Details)
ReleaseTaggerBot
added a project:
MW-1.39-notes (1.39.0-wmf.28; 2022-09-05)
Sep 1 2022, 9:00 PM
2022-09-01 21:00:43 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Sep 1 2022, 9:31 PM
2022-09-01 21:31:11 (UTC+0)
Jdlrobson
mentioned this in
T316908: [Potentially breaking change in Vector 2022] #p-namespaces element being replaced by #p-associated-pages
Sep 1 2022, 9:42 PM
2022-09-01 21:42:19 (UTC+0)
Jdlrobson
updated the task description.
(Show Details)
Quiddity
subscribed.
Sep 1 2022, 10:19 PM
2022-09-01 22:19:21 (UTC+0)
Comment Actions
One use-case that I commonly have for the single tab, is to reset a Special page back to its (or my) defaults. E.g.
I often open
and then change the/my default filters to see something specific
this automatically updates the address-bar URL (which is usually great!)
when I'm done, or if my tests weren't what I wanted, then instead of manually reverting each change, I click the Tab (which always points to the plain "Special:Foo" page instead of the parameterized version)
I'm not sure how widespread this workflow is (perhaps only me!) but thought I'd document it here.
Jdlrobson
added a comment.
Sep 1 2022, 11:16 PM
2022-09-01 23:16:20 (UTC+0)
Comment Actions
@Quiddity
thanks for sharing! I notice there's no "reset" button on Special:RecentChanges which might help with that particular workflow?
Quiddity
added a comment.
Sep 1 2022, 11:40 PM
2022-09-01 23:40:27 (UTC+0)
Comment Actions
Re: reset-button – One complexity is that there are both system-defaults and personal-defaults, and I'm not sure which I'd expect a "reset" button to result in.
E.g. my volunteer-account's personal-default is this "saved filter"
whereas the logged-out-user (system) default is
(Another minor(?) use-case: to access that 2nd URL, I right-clicked on the single-tab and clicked "open in private window"! I'm very used to it being there!)
Jonesey95
subscribed.
Edited
Sep 5 2022, 11:35 PM
2022-09-05 23:35:05 (UTC+0)
Comment Actions
Thanks for posting this in the Tech News. I have a similar concern to Quiddity's (posted at Thu, Sep 1, 15:19). I often want to duplicate a page in a new tab (e.g. to compare a page that I am actively fixing or have sorted to the page as it is currently rendered), so I hold down the Command key (Mac OS) and click the tab for the page. Quick and easy. Removing this tab will break this workflow.
I see that there are workarounds, like continuing to use the page-width-friendly legacy Vector, but I thought I would mention this case. I use this trick dozens of times every day.
Xover
subscribed.
Sep 6 2022, 6:06 AM
2022-09-06 06:06:24 (UTC+0)
Comment Actions
Gah. I'm religiously in favour of trimming away unneeded stuff in the UI (cf.
T163098
), but as I read the above comments I realise I rely on that behaviour too: for lots of pages I use the tab to get a "clean" (or just specific or predictable) version of the page, or a related page (i.e. talk vs. main vs. history etc.). And perhaps key here,
not just on special pages
. That is, if just special pages change (no tab but grow a reset button in the page-specific UI) I can't just retrain muscle memory, it'll end up being a constant impedance.
Not sure there's any actual solution to this; and not sure how big of an issue it'd be (or for how many; I imagine this workflow is pretty uncommon, but I could be wrong).
alexhollender_WMF
added a comment.
Sep 6 2022, 4:17 PM
2022-09-06 16:17:56 (UTC+0)
Comment Actions
@Quiddity
@Jonesey95
@Xover
thanks for letting us know about these use cases. I'm wondering if it would be acceptable if we removed the tab, and instead made the special page title (e.g. "Recent changes", etc.) a link to the "base" version of the special page (and it could also be right-clicked to to duplicate a page in a new tab)?
Jdlrobson
updated the task description.
(Show Details)
Sep 6 2022, 8:56 PM
2022-09-06 20:56:10 (UTC+0)
ovasileva
moved this task from
QA
to
Blocked on Others
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Sep 7 2022, 5:36 PM
2022-09-07 17:36:31 (UTC+0)
Comment Actions
Moving this to blocked so we can collect some feedback on whether people are running into more use cases this makes difficult.
alexhollender_WMF
added a comment.
Sep 8 2022, 2:58 PM
2022-09-08 14:58:30 (UTC+0)
Comment Actions
Discussion on our project talk page:
gerritbot
added a comment.
Sep 8 2022, 3:26 PM
2022-09-08 15:26:32 (UTC+0)
Comment Actions
Change 830888 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] [POC] Special page tab is restored to all special pages
gerritbot
added a project:
Patch-For-Review
Sep 8 2022, 3:26 PM
2022-09-08 15:26:33 (UTC+0)
gerritbot
added a comment.
Sep 8 2022, 3:31 PM
2022-09-08 15:31:23 (UTC+0)
Comment Actions
Change 830892 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Add tab to recent changes for resetting form
PatchDemoBot
added a comment.
Sep 8 2022, 3:35 PM
2022-09-08 15:35:30 (UTC+0)
Comment Actions
Test wiki
created
on
Patch demo
by Jdlrobson using patch(es) linked to this task:
Jdlrobson
added a comment.
Sep 8 2022, 3:36 PM
2022-09-08 15:36:37 (UTC+0)
Comment Actions
The new capability allows us to have more meaningful menus on these pages. My recommended solution would be to add a tab on RecentChanges with a more meaningful name then Special page (in example I've used "Filter").
Perhaps in future, saved filters could also go here to avoid the additional click?
ovasileva
edited parent tasks, added:
T317632: [EPIC] Visual refinements pt2
; removed:
T303549: Move titlebar above toolbar
Sep 13 2022, 12:30 PM
2022-09-13 12:30:07 (UTC+0)
Jdlrobson
removed
Edtadros
as the assignee of this task.
Sep 13 2022, 3:14 PM
2022-09-13 15:14:41 (UTC+0)
Jdlrobson
moved this task from
Blocked on Others
to
Ready for Signoff
on the
Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1)
board.
Jdlrobson
added a subscriber:
Edtadros
LGoto
assigned this task to
ovasileva
Sep 13 2022, 5:04 PM
2022-09-13 17:04:16 (UTC+0)
gerritbot
added a comment.
Sep 22 2022, 3:51 PM
2022-09-22 15:51:31 (UTC+0)
Comment Actions
Change 830888
abandoned
by Jdlrobson:
[mediawiki/core@master] [POC] Special page tab is restored to all special pages
Reason:
Doesn't seem to be needed.
gerritbot
added a comment.
Sep 22 2022, 3:51 PM
2022-09-22 15:51:54 (UTC+0)
Comment Actions
Change 830892
abandoned
by Jdlrobson:
[mediawiki/core@master] [POC] Add tab to recent changes for resetting form
Reason:
Doesn't seem to be needed. Please open a new ticket and restore if so.
Maintenance_bot
removed a project:
Patch-For-Review
Sep 22 2022, 4:31 PM
2022-09-22 16:31:04 (UTC+0)
ovasileva
closed this task as
Resolved
Sep 30 2022, 1:32 PM
2022-09-30 13:32:37 (UTC+0)
Comment Actions
All done here, will re-open if more concerns arise.
PatchDemoBot
added a comment.
Feb 3 2023, 3:42 PM
2023-02-03 15:42:40 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by Jdlrobson using patch(es) linked to this task was
deleted
PatchDemoBot
added a comment.
Feb 3 2023, 3:43 PM
2023-02-03 15:43:04 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by Jdlrobson using patch(es) linked to this task was
deleted
PatchDemoBot
added a comment.
Jul 31 2023, 1:31 PM
2023-07-31 13:31:47 (UTC+0)
Comment Actions
Test wiki on
Patch demo
by Jdlrobson using patch(es) linked to this task was
deleted
Jdlrobson
mentioned this in
T347907: Drop support for addPortletLink with #p-namespaces in Vector 2022 skin
Oct 2 2023, 8:00 PM
2023-10-02 20:00:20 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits