⚓ T321551 PHP Warning: Invalid argument supplied for foreach() in Special:ProtectedTitles page
Page Menu
Phabricator
Create Task
Maniphest
T321551
PHP Warning: Invalid argument supplied for foreach() in Special:ProtectedTitles page
Closed, Resolved
Public
PRODUCTION ERROR
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Umherirrender
Authored By
jnuche
Oct 25 2022, 11:21 AM
2022-10-25 11:21:53 (UTC+0)
Tags
Wikimedia-production-error
(Oct 2022)
MediaWiki-Special-pages
(To triage)
Patch-For-Review
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
MW-1.39-notes
Referenced Files
None
Subscribers
Aklapper
jnuche
Umherirrender
Description
Error
mwversion:
1.40.0-wmf.7
reqId:
98017ff4-1964-4d1f-a5bd-dd7b0cbcfa73
Find reqId in Logstash
normalized_message
[{reqId}] {exception_url} PHP Warning: Invalid argument supplied for foreach()
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.7/includes/pager/AlphabeticPager.php(51)
#0 /srv/mediawiki/php-1.40.0-wmf.7/includes/pager/AlphabeticPager.php(51): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.7/includes/specials/SpecialProtectedtitles.php(84): AlphabeticPager->getNavigationBar()
#2 /srv/mediawiki/php-1.40.0-wmf.7/includes/specialpage/SpecialPage.php(701): SpecialProtectedtitles->execute(NULL)
#3 /srv/mediawiki/php-1.40.0-wmf.7/includes/specialpage/SpecialPageFactory.php(1451): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(904): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(562): MediaWiki->main()
#7 /srv/mediawiki/php-1.40.0-wmf.7/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.40.0-wmf.7/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}
Notes
Observed on mediawikiwiki after deployment of
1.40.0-wmf.7
to group 0.
Reproduces consistently by hitting the
Special:ProtectedTitles
page:
Main rendering of the page doesn't seem affected. Other special pages don't seem affected.
Details
Request URL
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
pager: Fix null used for foreach in Pager::getNavigationBar
mediawiki/core
master
+15
-14
pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
mediawiki/core
REL1_39
+2
-36
pager: Fix null used for foreach in Pager::getNavigationBar
mediawiki/core
REL1_39
+15
-14
pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
mediawiki/core
master
+2
-36
Customize query in gerrit
Related Objects
Mentions
Mentioned In
T321679: PHP Notice: Array to string conversion in Special:NewFiles
Event Timeline
jnuche
created this task.
Oct 25 2022, 11:21 AM
2022-10-25 11:21:53 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Oct 25 2022, 11:21 AM
2022-10-25 11:21:53 (UTC+0)
jnuche
renamed this task from
PHP Warning: Invalid argument supplied for foreach()
to
PHP Warning: Invalid argument supplied for foreach() in Special:ProtectedTitles page
Oct 25 2022, 11:24 AM
2022-10-25 11:24:46 (UTC+0)
Umherirrender
claimed this task.
Oct 25 2022, 5:18 PM
2022-10-25 17:18:49 (UTC+0)
Umherirrender
subscribed.
Comment Actions
The code path is only reached when
Pager::getIndexField
returns an array, which is true since
for that special page (and some others) and the navigation bar is shown, which has happen after 50 entries. My test wiki does not have that many pages protected, but with a limit=1 I can see it as well.
gerritbot
added a comment.
Oct 25 2022, 5:27 PM
2022-10-25 17:27:53 (UTC+0)
Comment Actions
Change 849132 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] pager: Fix null used for foreach in Pager::getNavigationBar
gerritbot
added a project:
Patch-For-Review
Oct 25 2022, 5:27 PM
2022-10-25 17:27:53 (UTC+0)
jnuche
mentioned this in
T321679: PHP Notice: Array to string conversion in Special:NewFiles
Oct 26 2022, 12:03 PM
2022-10-26 12:03:21 (UTC+0)
gerritbot
added a comment.
Oct 29 2022, 12:26 AM
2022-10-29 00:26:43 (UTC+0)
Comment Actions
Change 850612 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
Krinkle
moved this task from
Untriaged
to
Oct 2022
on the
Wikimedia-production-error
board.
Oct 29 2022, 12:32 AM
2022-10-29 00:32:12 (UTC+0)
gerritbot
added a comment.
Oct 29 2022, 12:42 AM
2022-10-29 00:42:39 (UTC+0)
Comment Actions
Change 849132
merged
by jenkins-bot:
[mediawiki/core@master] pager: Fix null used for foreach in Pager::getNavigationBar
ReleaseTaggerBot
added a project:
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Oct 29 2022, 1:00 AM
2022-10-29 01:00:43 (UTC+0)
Umherirrender
closed this task as
Resolved
Oct 31 2022, 9:30 PM
2022-10-31 21:30:58 (UTC+0)
Comment Actions
The production error is fixed
gerritbot
added a comment.
Nov 2 2022, 6:58 PM
2022-11-02 18:58:50 (UTC+0)
Comment Actions
Change 850612
merged
by jenkins-bot:
[mediawiki/core@master] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
; removed
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Nov 2 2022, 7:00 PM
2022-11-02 19:00:41 (UTC+0)
gerritbot
added a comment.
Nov 3 2022, 9:26 PM
2022-11-03 21:26:36 (UTC+0)
Comment Actions
Change 853027 had a related patch set uploaded (by Bartosz Dziewoński; author: Umherirrender):
[mediawiki/core@REL1_39] pager: Fix null used for foreach in Pager::getNavigationBar
gerritbot
added a comment.
Nov 3 2022, 9:27 PM
2022-11-03 21:27:06 (UTC+0)
Comment Actions
Change 853028 had a related patch set uploaded (by Bartosz Dziewoński; author: Krinkle):
[mediawiki/core@REL1_39] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
gerritbot
added a comment.
Nov 3 2022, 9:50 PM
2022-11-03 21:50:04 (UTC+0)
Comment Actions
Change 853027
merged
by jenkins-bot:
[mediawiki/core@REL1_39] pager: Fix null used for foreach in Pager::getNavigationBar
gerritbot
added a comment.
Nov 3 2022, 9:50 PM
2022-11-03 21:50:10 (UTC+0)
Comment Actions
Change 853028
merged
by jenkins-bot:
[mediawiki/core@REL1_39] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support
ReleaseTaggerBot
added a project:
MW-1.39-notes
Nov 3 2022, 10:00 PM
2022-11-03 22:00:57 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits