⚓ T321692 FileImporter support for PHP 8.1

⚓ T321692 FileImporter support for PHP 8.1
Page Menu
Phabricator
Create Task
Maniphest
T321692
FileImporter support for PHP 8.1
Closed, Resolved
Public
1 Estimated Story Points
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
thiemowmde
Authored By
Jdforrester-WMF
Oct 26 2022, 1:35 PM
2022-10-26 13:35:15 (UTC+0)
Tags
PHP 8.1 support
(Wikimedia production)
Move-Files-To-Commons
(Tickets in sprint)
WMDE-TechWish
WMDE-TechWish-Maintenance
(Incoming)
WMDE-TechWish-Sprint-2022-10-26
(Done)
Unplanned-Sprint-Work
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
Referenced Files
None
Subscribers
Aklapper
Jdforrester-WMF
tstarling
Description
00:01:20.716 1) FileImporter\Tests\Exceptions\ImportExceptionTest::testException with data set #3 (1.2, 1.2)
00:01:20.716 ctype_digit(): Argument of type float will be interpreted as string in the future
00:01:20.716
00:01:20.716 /workspace/src/extensions/FileImporter/src/Exceptions/ImportException.php:23
00:01:20.716 /workspace/src/extensions/FileImporter/tests/phpunit/unit/Exceptions/ImportExceptionTest.php:30
00:01:20.716 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Avoid passing non-strings to ctype_digit()
mediawiki/extensions/FileImporter
REL1_39
+5
-1
Fix PHP 8.1 test failures
mediawiki/extensions/FileImporter
master
+47
-22
Avoid passing non-strings to ctype_digit()
mediawiki/extensions/FileImporter
master
+5
-1
Customize query in gerrit
Related Objects
Search...
Task Graph
Status
Subtype
Assigned
Task
Resolved
None
T396296
Upgrade symfony/* to PHP 8.1 versions
Resolved
Reedy
T373753
Drop symfony/polyfill-php 73-81 from mediawiki-vendor
Stalled
None
T255792
Quibble runs core:unit tests twice!
Open
None
T232915
Red-green in PHPUnit code coverage are hard to read
Open
None
T376276
PHP 8.4: Implicitly nullable parameter declarations deprecated
Open
None
T379587
PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Resolved
Reedy
T378424
PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Resolved
Krinkle
T358666
Drop PHP 8.1 support from MediaWiki
Resolved
Krinkle
T360995
Migrate Wikimedia production from PHP 8.1 to PHP 8.3
Resolved
Jdforrester-WMF
T353362
Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T352085
Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T360560
Make PHP 8.2 voting on development branch of Wikibase
Resolved
Lucas_Werkmeister_WMDE
T324202
Remove use of utf8_encode and utf8_decode in Wikibase
Resolved
None
T353161
[CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
Resolved
Jdforrester-WMF
T360709
Make PHP 8.2 voting on development (master) branch of Math extension
Resolved
Daimona
T381728
Use PHP 8.3 in MediaWiki-Docker
Resolved
Jdforrester-WMF
T398491
Move CI images to WMF PHP 8.3 packages
Declined
None
T401255
Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF
Resolved
Scott_French
T401254
Upgrade mw-debug/next to PHP 8.3
Resolved
Scott_French
T401252
Configure title-case consistency mapping for PHP 8.1 -> 8.3 transition
Resolved
Scott_French
T399884
Configure production MediaWiki image builds for PHP 8.3
Resolved
cscott
T401855
☂ PHP 8.3 issues found during WMF rollout
Resolved
Scott_French
T402424
PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
Duplicate
PRODUCTION ERROR
None
T403514
Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
Resolved
PRODUCTION ERROR
Michael
T407403
Error: Invalid serialization data for DatePeriod object
Resolved
PRODUCTION ERROR
Michael
T408852
PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
Resolved
Michael
T401005
Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
Duplicate
PRODUCTION ERROR
None
T409248
PHP Warning: Trying to access array offset on null
Resolved
Tgr
T402597
Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
Resolved
None
T402804
Exploratory testing on PHP 8.3 for MediaWiki authentication stack
Resolved
DAlangi_WMF
T403484
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login
Resolved
Tgr
T403485
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session
Resolved
DAlangi_WMF
T403486
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup
Resolved
Tgr
T403487
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth
Resolved
Tgr
T403488
Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA
Resolved
Atieno
T402809
Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components
Open
None
T402810
Exploratory testing on PHP 8.3 for Content Transform Team components
Resolved
brouberol
T403110
Prepare dumps-on-k8s (mediawiki-dumps-legacy) for migration to PHP 8.3
Resolved
Scott_French
T403655
Configure mw-next-routing for the PHP 8.3 migration
Resolved
Scott_French
T403657
Configure the WikimediaEvents extension for the PHP 8.3 migration
Resolved
Scott_French
T403284
Migrate production Shellbox services to PHP 8.3
Resolved
Scott_French
T403283
Prepare PHP 8.3 service images for Shellbox
Resolved
Scott_French
T398246
Prepare PHP 8.3 production images
Resolved
Scott_French
T398245
Prepare WMF PHP 8.3 packages for bullseye
Resolved
Krinkle
T400109
Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3)
Resolved
Krinkle
T401152
Switch wmf-config/Profiler from Tideways to XHProf
Resolved
Scott_French
T403772
Migrate parsoidtest1001 to PHP 8.3
Resolved
Krinkle
T405031
lcobucci/clock needs upgrading for PHP 8.3
Resolved
Tgr
T363639
web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
Resolved
Scott_French
T405955
MediaWiki on PHP 8.3 production workload migration
Resolved
jnuche
T411277
Patchdemo wiki creation fails due to PHP 8.1 not supported by MW
Resolved
Jdforrester-WMF
T411372
wikilambda-catalyst-end-to-end broken due to new version of composer after PHP 8.1 -> 8.3 migration
Resolved
BUG REPORT
bd808
T411235
Beta cluster scap using php8.1 container; php8.2 is now required
Resolved
Reedy
T380185
Prepare for newer geoip2/geoip2 library
Resolved
Reedy
T338103
Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Resolved
seanleong-WMDE
T379930
Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled
None
T334726
Use return type `never` in Wikibase
Open
None
T328919
Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Resolved
Lucas_Werkmeister_WMDE
T328741
Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
Resolved
Daimona
T342110
Upgrade to PHPUnit 9.6
Resolved
Daimona
T342259
Move MediaWikiIntegrationTestCase setup and teardown away from run()
Resolved
Daimona
T342301
Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
Open
None
T332865
PHPUnit data providers should be simple static functions that return plain data
Resolved
Umherirrender
T337130
Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
Resolved
Arendpieter
T337135
Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
Resolved
Umherirrender
T337144
Make PHPUnit dataProvider static in AbuseFilter tests
Resolved
Umherirrender
T337155
Make PHPUnit dataProvider static in ReadingLists tests
Resolved
mszabo
T337156
Make PHPUnit dataProvider static in IPInfo tests
Resolved
tstarling
T337157
Make PHPUnit dataProvider static in LoginNotify tests
Resolved
Umherirrender
T337158
Make PHPUnit dataProvider static in Flow tests
Resolved
Dreamy_Jazz
T337159
Make PHPUnit dataProvider static in CheckUser tests
Resolved
Dreamy_Jazz
T346044
Remove CheckUserUnionQueryBuilder
Resolved
Physikerwelt
T337160
Make PHPUnit dataProvider static in Math tests
Resolved
Tgr
T337161
Make PHPUnit dataProvider static in OAuth tests
Resolved
Umherirrender
T337162
Make PHPUnit dataProvider static in ProofreadPage tests
Resolved
Umherirrender
T337163
Make PHPUnit dataProvider static in CirrusSearch tests
Resolved
None
T337164
Make PHPUnit dataProvider static in FileImporter tests
Resolved
Umherirrender
T337165
Make PHPUnit dataProvider static in GrowthExperiments tests
Resolved
None
T337166
Make PHPUnit dataProvider static in CampaignEvents tests
Resolved
None
T371467
[GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
Resolved
karapayneWMDE
T337154
Make PHPUnit dataProvider static in Wikibase tests
Resolved
AudreyPenven_WMDE
T380604
Make provideLuaData static
Resolved
AudreyPenven_WMDE
T380605
Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
Resolved
Lucas_Werkmeister_WMDE
T337153
Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
Resolved
Lucas_Werkmeister_WMDE
T337151
Make PHPUnit dataProvider static in WikibaseLexeme tests
Resolved
Umherirrender
T337152
Make PHPUnit dataProvider static in WikibaseMediaInfo tests
Resolved
thiemowmde
T337150
Make PHPUnit dataProvider static in Wikidata.org tests
Resolved
Lucas_Werkmeister_WMDE
T337148
Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Resolved
Umherirrender
T393065
Make PHPUnit dataProvider on ExtensionJsonTestBase static
Resolved
Umherirrender
T393079
Make PHPUnit dataProvider static in CommunityConfiguration tests
Resolved
Umherirrender
T393080
Make PHPUnit dataProvider static in AutoModerator tests
Resolved
Umherirrender
T393081
Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
Resolved
Umherirrender
T393082
Make PHPUnit dataProvider on OutputTransformStageTestBase static
Resolved
Umherirrender
T393084
Make PHPUnit dataProvider on TypeDefTestCaseTrait static
Resolved
mszabo
T393115
Make PHPUnit dataProvider on PasswordTestCase static
Resolved
xSavitar
T393122
Make PHPUnit dataProvider on BundleSizeTestBase static
Resolved
Umherirrender
T393132
Make PHPUnit dataProvider on RevisionRecordTests static
Resolved
Umherirrender
T393207
Make PHPUnit dataProvider on ExtensionServicesTestBase static
Resolved
Umherirrender
T393219
Make PHPUnit dataProvider on RestStructureTest static
Resolved
Umherirrender
T410731
Fix all Wikimedia production code and MW extensions PHPUnit tests data providers real providers (and use static methods)
Open
None
T345481
Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
Open
None
T422866
Migrate parser tests to new phpunit:config mechanism
Resolved
Arendpieter
T358394
Stop using internal PHPUnit code in Scribunto
Open
None
T363064
MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
Resolved
Umherirrender
T363641
IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Resolved
larissagaulia
T363650
Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Resolved
Umherirrender
T362858
equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
Resolved
Jdforrester-WMF
T395743
Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
Open
None
T420851
Use of ExtensionJsonTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420853
Use of AbstractSchemaTestBase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420854
LuaEngineTestBase causes "Empty data set provided by data provider" failures for lua errors under PHPUnit 10
Open
None
T420856
Use of HTMLFormFieldTestCase causes "Empty data set provided by data provider" failures under PHPUnit 10
Open
None
T420857
Skipping in EnWikiFormulaeTest does not work under PHPUnit 10
Open
None
T420859
EntityHandlerTestCase causes invalid data provider failures under PHPUnit 10
Open
None
T420860
OutputTransformStageTestBase causes invalid data provider failures under PHPUnit 10
Resolved
Umherirrender
T421178
Fix PHPUnit 10 deprecation notice "Providing invalid named argument $... for method ... is deprecated and will not be supported in PHPUnit 11.0." in wmf deployed code
Resolved
Jdforrester-WMF
T319055
Upgrade to psr/container 2.x
Resolved
Jdforrester-WMF
T328921
Drop PHP 7.4 and PHP 8.0 support from MediaWiki
Resolved
Krinkle
T319432
Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved
Jdforrester-WMF
T316078
Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved
Jdforrester-WMF
T319065
All Wikimedia production extensions and skins must support PHP 8.1
Resolved
thiemowmde
T321692
FileImporter support for PHP 8.1
Event Timeline
Jdforrester-WMF
created this task.
Oct 26 2022, 1:35 PM
2022-10-26 13:35:15 (UTC+0)
Reedy
moved this task from
Backlog
to
Wikimedia production
on the
PHP 8.1 support
board.
Oct 26 2022, 3:56 PM
2022-10-26 15:56:49 (UTC+0)
Krinkle
added a project:
WMDE-TechWish
Oct 27 2022, 3:16 AM
2022-10-27 03:16:25 (UTC+0)
gerritbot
added a comment.
Oct 27 2022, 8:02 AM
2022-10-27 08:02:37 (UTC+0)
Comment Actions
Change 850026 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Avoid passing non-strings to ctype_digit()
gerritbot
added a project:
Patch-For-Review
Oct 27 2022, 8:02 AM
2022-10-27 08:02:37 (UTC+0)
thiemowmde
claimed this task.
Oct 27 2022, 8:03 AM
2022-10-27 08:03:43 (UTC+0)
thiemowmde
added projects:
WMDE-TechWish-Maintenance
WMDE-TechWish-Sprint-2022-10-26
Unplanned-Sprint-Work
thiemowmde
moved this task from
Backlog
to
Tickets in sprint
on the
Move-Files-To-Commons
board.
thiemowmde
set the point value for this task to
thiemowmde
moved this task from
Sprint Backlog
to
Tech Review
on the
WMDE-TechWish-Sprint-2022-10-26
board.
WMDE-Fisch
moved this task from
Tech Review
to
Done
on the
WMDE-TechWish-Sprint-2022-10-26
board.
Oct 27 2022, 10:05 AM
2022-10-27 10:05:31 (UTC+0)
gerritbot
added a comment.
Oct 27 2022, 10:23 AM
2022-10-27 10:23:24 (UTC+0)
Comment Actions
Change 850026
merged
by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Avoid passing non-strings to ctype_digit()
Maintenance_bot
removed a project:
Patch-For-Review
Oct 27 2022, 10:32 AM
2022-10-27 10:32:58 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Oct 27 2022, 11:00 AM
2022-10-27 11:00:40 (UTC+0)
Jdforrester-WMF
closed this task as
Resolved
Oct 28 2022, 4:40 PM
2022-10-28 16:40:56 (UTC+0)
Comment Actions
Thank you!
tstarling
reopened this task as
Open
Nov 1 2022, 2:18 AM
2022-11-01 02:18:39 (UTC+0)
tstarling
subscribed.
Comment Actions
1) FileImporter\Tests\Data\ImportDetailsTest::testInvalidFileRevisionTimestamp
strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

/srv/mw/extensions/FileImporter/src/Data/FileRevisions.php:54
/srv/mw/extensions/FileImporter/src/Data/FileRevisions.php:41
/srv/mw/extensions/FileImporter/src/Data/ImportDetails.php:121
/srv/mw/extensions/FileImporter/tests/phpunit/Data/ImportDetailsTest.php:73

2) FileImporter\Tests\Remote\MediaWiki\RemoteApiImportTitleCheckerTest::test with data set #7 (null, false, 1)
json_decode(): Passing null to parameter #1 ($json) of type string is deprecated

/srv/mw/extensions/FileImporter/src/Remote/MediaWiki/RemoteApiImportTitleChecker.php:67
/srv/mw/extensions/FileImporter/tests/phpunit/Remote/MediaWiki/RemoteApiImportTitleCheckerTest.php:71
tstarling
added a comment.
Nov 1 2022, 2:27 AM
2022-11-01 02:27:13 (UTC+0)
Comment Actions
Tests where everything is mocked, the fields are null, validation is disabled, and then you call random methods and expect them to work. Fragile and sensitive to private details of the classes being tested.
gerritbot
added a comment.
Nov 1 2022, 3:20 AM
2022-11-01 03:20:40 (UTC+0)
Comment Actions
Change 851181 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/extensions/FileImporter@master] Fix PHP 8.1 test failures
gerritbot
added a project:
Patch-For-Review
Nov 1 2022, 3:20 AM
2022-11-01 03:20:40 (UTC+0)
gerritbot
added a comment.
Nov 1 2022, 8:34 AM
2022-11-01 08:34:57 (UTC+0)
Comment Actions
Change 851181
merged
by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix PHP 8.1 test failures
ReleaseTaggerBot
edited projects, added
MW-1.40-notes (1.40.0-wmf.10; 2022-11-14)
; removed
MW-1.40-notes (1.40.0-wmf.8; 2022-10-31)
Nov 1 2022, 9:01 AM
2022-11-01 09:01:13 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Nov 1 2022, 9:30 AM
2022-11-01 09:30:02 (UTC+0)
Jdforrester-WMF
closed this task as
Resolved
Nov 2 2022, 4:27 PM
2022-11-02 16:27:11 (UTC+0)
gerritbot
added a comment.
Jun 18 2025, 5:22 PM
2025-06-18 17:22:59 (UTC+0)
Comment Actions
Change #1160925 had a related patch set uploaded (by Reedy; author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@REL1_39] Avoid passing non-strings to ctype_digit()
gerritbot
added a project:
Patch-For-Review
Jun 18 2025, 5:23 PM
2025-06-18 17:23:00 (UTC+0)
gerritbot
added a comment.
Aug 13 2025, 7:44 PM
2025-08-13 19:44:13 (UTC+0)
Comment Actions
Change #1160925
merged
by Umherirrender:
[mediawiki/extensions/FileImporter@REL1_39] Avoid passing non-strings to ctype_digit()
Maintenance_bot
removed a project:
Patch-For-Review
Aug 13 2025, 8:31 PM
2025-08-13 20:31:26 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits