⚓ T327281 Use correct legal wording for preference for viewing IP addresses used by temporary accounts

⚓ T327281 Use correct legal wording for preference for viewing IP addresses used by temporary accounts
Page Menu
Phabricator
Create Task
Maniphest
T327281
Use correct legal wording for preference for viewing IP addresses used by temporary accounts
Closed, Resolved
Public
2 Estimated Story Points
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Dreamy_Jazz
Authored By
Tchanders
Jan 18 2023, 1:41 PM
2023-01-18 13:41:19 (UTC+0)
Tags
Temporary accounts
(Inbox)
MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 )
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
(Done)
MW-1.43-notes (1.43.0-wmf.4; 2024-05-07)
Referenced Files
F49735632: image.png
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
F49734728: image.png
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
F49731321: image.png
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
F49721926: image.png
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
F49716119: image.png
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
F49490791: image.png
Apr 30 2024, 5:57 PM
2024-04-30 17:57:04 (UTC+0)
F42028312: image.png
Feb 21 2024, 9:24 PM
2024-02-21 21:24:01 (UTC+0)
F41649978: 2024-01-03_10-00-07.png
Jan 4 2024, 12:26 AM
2024-01-04 00:26:49 (UTC+0)
View All 9 Files
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz
GMikesell-WMF
Izno
Madalina
Niharika
View All 11 Subscribers
Description
Background
This preference was added in
T326736: Create preference for viewing IP addresses used by temporary accounts
. We want to update the preference wording based on Legal's advice.
Acceptance criteria
Update the preference text to the following:
Before enabling this setting, you must read and agree to the “
Access to Temporary Account IP Addresses Policy
”. In particular:
You must meet the eligibility criteria described in the Policy;
You must not access, use or disclose information about temporary account IP addresses except if it is reasonably necessary for the
investigation of or enforcement against vandalism, abuse, spam, harassment, disruptive behavior, and other violations of Wikimedia Foundation or community policies
. If you do share the information with others, you must be sensitive about where and how you do that, and you should remove the information when it is no longer reasonably necessary for others to see it.
If you have read and agree to the Policy, you may enable the preference by checking the checkbox.
QA Results - Patch Demo
AC
Status
Details
here
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Use bullet points in the temporary account preference description
mediawiki/extensions/WikimediaMessages
master
+3
-3
Add description text for temporary account viewing preference
mediawiki/extensions/CheckUser
master
+94
-61
Override message checkuser-tempaccount-enable-preference
mediawiki/extensions/WikimediaMessages
master
+4
-0
Add 'checkuser-tempaccount-preference' class to temp account preference
mediawiki/extensions/CheckUser
master
+1
-0
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Restricted Task
Resolved
kostajh
T294511
2021 Security Team wikireplicas audit
Declined
None
T284948
Raw IPs of logged-out users disclosed in wiki-replicas
Resolved
Niharika
T324492
Temporary accounts - MVP
In Progress
Niharika
T325451
[Epic] Users with right privileges are able to view IP addresses
Resolved
Dreamy_Jazz
T327281
Use correct legal wording for preference for viewing IP addresses used by temporary accounts
Mentioned In
T315774: WikimediaMessages has no PHPUnit tests
T326736: Create preference for viewing IP addresses used by temporary accounts
Mentioned Here
T326736: Create preference for viewing IP addresses used by temporary accounts
Event Timeline
Tchanders
created this task.
Jan 18 2023, 1:41 PM
2023-01-18 13:41:19 (UTC+0)
Tchanders
added a subtask:
T327061: Enable temp account ip viewing preference by default for checkusers
Tchanders
removed a subtask:
T327061: Enable temp account ip viewing preference by default for checkusers
Tchanders
added a project:
Anti-Harassment-Team
Tchanders
mentioned this in
T326736: Create preference for viewing IP addresses used by temporary accounts
Jan 18 2023, 1:46 PM
2023-01-18 13:46:55 (UTC+0)
Tchanders
changed the task status from
Open
to
Stalled
Mar 3 2023, 5:37 PM
2023-03-03 17:37:55 (UTC+0)
Comment Actions
Stalled pending legal advice
Niharika
updated the task description.
(Show Details)
Nov 29 2023, 1:15 AM
2023-11-29 01:15:58 (UTC+0)
Tchanders
changed the task status from
Stalled
to
Open
Nov 29 2023, 9:49 AM
2023-11-29 09:49:27 (UTC+0)
Tchanders
edited projects, added
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
; removed
Anti-Harassment-Team
Dec 12 2023, 5:54 PM
2023-12-12 17:54:10 (UTC+0)
Dreamy_Jazz
claimed this task.
Dec 20 2023, 5:32 PM
2023-12-20 17:32:21 (UTC+0)
Dreamy_Jazz
moved this task from
Priority Backlog
to
In Progress
on the
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
board.
Dec 20 2023, 5:37 PM
2023-12-20 17:37:10 (UTC+0)
gerritbot
added a comment.
Dec 20 2023, 5:51 PM
2023-12-20 17:51:08 (UTC+0)
Comment Actions
Change 984629 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/WikimediaMessages@master] Override message checkuser-tempaccount-enable-preference
gerritbot
added a project:
Patch-For-Review
Dec 20 2023, 5:51 PM
2023-12-20 17:51:09 (UTC+0)
Dreamy_Jazz
mentioned this in
T315774: WikimediaMessages has no PHPUnit tests
Dec 21 2023, 12:15 AM
2023-12-21 00:15:43 (UTC+0)
Dreamy_Jazz
moved this task from
In Progress
to
Needs review
on the
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
board.
Dec 21 2023, 12:25 AM
2023-12-21 00:25:54 (UTC+0)
Dreamy_Jazz
removed a project:
Epic
gerritbot
added a comment.
Dec 21 2023, 12:46 AM
2023-12-21 00:46:42 (UTC+0)
Comment Actions
Change 984656 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Add 'checkuser-tempaccount-preference' class to temp account preference
Dreamy_Jazz
set the point value for this task to
Dec 21 2023, 11:44 PM
2023-12-21 23:44:11 (UTC+0)
Niharika
added a comment.
Dec 22 2023, 1:50 AM
2023-12-22 01:50:37 (UTC+0)
Comment Actions
Current design:
Niharika
added a subscriber:
PBradley-WMF
Dec 22 2023, 1:54 AM
2023-12-22 01:54:04 (UTC+0)
Comment Actions
@PBradley-WMF
I have included a mock for what this look like in a comment above. Can you please confirm if it looks OK?
And for the link to the policy - the link you provided originally was for the
Minimum requirements section
. Is that intentional?
The current patch links to the entire page. That can be changed if you feel the section is more appropriate.
gerritbot
added a comment.
Jan 3 2024, 10:24 AM
2024-01-03 10:24:52 (UTC+0)
Comment Actions
Change 984656
abandoned
by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Add 'checkuser-tempaccount-preference' class to temp account preference
Reason:
No longer needed
gerritbot
added a comment.
Jan 3 2024, 2:18 PM
2024-01-03 14:18:40 (UTC+0)
Comment Actions
Change 984629
merged
by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Override message checkuser-tempaccount-enable-preference
Tchanders
moved this task from
Needs review
to
Needs QA
on the
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
board.
Jan 3 2024, 2:23 PM
2024-01-03 14:23:32 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Jan 3 2024, 2:31 PM
2024-01-03 14:31:30 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 )
Jan 3 2024, 3:00 PM
2024-01-03 15:00:41 (UTC+0)
Dreamy_Jazz
added a comment.
Edited
Jan 3 2024, 3:27 PM
2024-01-03 15:27:42 (UTC+0)
Comment Actions
Suggested QA steps (can be performed on patchdemo):
Install CheckUser and WikimediaMessages extensions (if necessary)
Log in to an account that has the
checkuser-temporary-account
group (on patch demos this is the
Patch Demo
account)
Load Special:Preferences
Scroll down to the bottom while on the first tab named
User profile
Verify that the section with the
Temporary account IP reveal
heading looks like the following:
GMikesell-WMF
subscribed.
Jan 4 2024, 12:26 AM
2024-01-04 00:26:49 (UTC+0)
Comment Actions
@Dreamy_Jazz
The
Temporary account IP reveal
heading matches as seen in the screenshot below. This will be moved to Done. Thanks for all your work!
Status:
✅PASS
Environment:
Patch Demo w/Checkuser & WikimediaMessages
OS:
macOS Sonoma 14.2.1
Browser:
Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins.
Vector
Device:
MBA M2
Emulated Device:
: n/a
Test Links:
✅AC1:
GMikesell-WMF
updated the task description.
(Show Details)
Jan 4 2024, 12:27 AM
2024-01-04 00:27:47 (UTC+0)
GMikesell-WMF
moved this task from
Needs QA
to
Done
on the
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
board.
Dreamy_Jazz
moved this task from
Sprint Lute (11th Dec. - 22nd Dec. 2023)
to
Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)
on the
Trust and Safety Product Sprint
board.
Jan 8 2024, 4:14 PM
2024-01-08 16:14:48 (UTC+0)
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24))
; removed
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
; removed
Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24))
Jan 8 2024, 4:16 PM
2024-01-08 16:16:49 (UTC+0)
Dreamy_Jazz
reassigned this task from
Dreamy_Jazz
to
Madalina
Jan 29 2024, 2:39 PM
2024-01-29 14:39:47 (UTC+0)
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024))
; removed
Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023))
Dreamy_Jazz
added subscribers:
Madalina
Dreamy_Jazz
Comment Actions
Re-assigning to
@Madalina
so that we can get clarification from Legal whether the updated wording is acceptable.
Dreamy_Jazz
moved this task from
Priority Backlog
to
In Progress
on the
Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024))
board.
Jan 29 2024, 2:40 PM
2024-01-29 14:40:50 (UTC+0)
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March))
; removed
Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024))
Feb 20 2024, 1:01 AM
2024-02-20 01:01:48 (UTC+0)
PBradley-WMF
added a comment.
Feb 20 2024, 10:55 AM
2024-02-20 10:55:16 (UTC+0)
Comment Actions
I'm OK with the wording/design from a legal point of view. As to
Niharika's question to me above about URL destination
: it's fine to link to the whole Policy.
Design-wise, two thoughts:
the two paras starting "You..." should be shown as list items!
is it clear enough to users
what
this checkbox does? Does that need a brief explanation here?
Dreamy_Jazz
added a comment.
Edited
Feb 21 2024, 9:24 PM
2024-02-21 21:24:01 (UTC+0)
Comment Actions
In
T327281#9558369
@PBradley-WMF
wrote:
Design-wise, two thoughts:
the two paras starting "You..." should be shown as list items!
Mock-up for what this looks like:
Dreamy_Jazz
added a comment.
Mar 5 2024, 4:24 PM
2024-03-05 16:24:11 (UTC+0)
This comment was removed by
Dreamy_Jazz
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March))
; removed
Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March))
Mar 11 2024, 5:02 PM
2024-03-11 17:02:22 (UTC+0)
Dreamy_Jazz
moved this task from
Priority Backlog
to
In Progress
on the
Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March))
board.
Mar 13 2024, 1:42 PM
2024-03-13 13:42:45 (UTC+0)
Samwalton9-WMF
subscribed.
Apr 30 2024, 12:19 PM
2024-04-30 12:19:36 (UTC+0)
Comment Actions
In
T327281#9565295
@Dreamy_Jazz
wrote:
In
T327281#9558369
@PBradley-WMF
wrote:
Design-wise, two thoughts:
the two paras starting "You..." should be shown as list items!
Mock-up for what this looks like:
Has this change been merged? It seems like a clear improvement to me.
is it clear enough to users what this checkbox does? Does that need a brief explanation here?
I agree with this concern - the checkbox doesn't have any 'action' associated with it, instead going straight into the policy requirements. Perhaps we could add one sentence at the start like:
Enable ability to reveal IP addresses for temporary accounts
Wordsmithing welcomed!
Dreamy_Jazz
claimed this task.
Edited
Apr 30 2024, 2:55 PM
2024-04-30 14:55:32 (UTC+0)
Dreamy_Jazz
edited projects, added
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
; removed
Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March))
Comment Actions
In
T327281#9757499
@Samwalton9-WMF
wrote:
In
T327281#9565295
@Dreamy_Jazz
wrote:
In
T327281#9558369
@PBradley-WMF
wrote:
Design-wise, two thoughts:
the two paras starting "You..." should be shown as list items!
Mock-up for what this looks like:
Has this change been merged? It seems like a clear improvement to me.
No, this has not been merged. I can work on a patch for that.
The HTML specification does not allow bullet points in this area (see
). I had forgot about that when I made the comment above with the mockup. While it worked on Chrome, there is no guarantee it would work on other browsers.
The alternative is to put the text above the checkbox but in the same section as shown below:
is it clear enough to users what this checkbox does? Does that need a brief explanation here?
I agree with this concern - the checkbox doesn't have any 'action' associated with it, instead going straight into the policy requirements. Perhaps we could add one sentence at the start like:
Enable ability to reveal IP addresses for temporary accounts
Wordsmithing welcomed!
I can use your suggested wording in the change to implement the use of bullet points. That can be updated easily in the patch before it is merged if it needs modification.
Dreamy_Jazz
moved this task from
Priority Backlog
to
In Progress
on the
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
board.
Apr 30 2024, 2:55 PM
2024-04-30 14:55:40 (UTC+0)
Dreamy_Jazz
attached a referenced file:
F49490791: image.png
(Show Details)
Apr 30 2024, 5:57 PM
2024-04-30 17:57:10 (UTC+0)
gerritbot
added a comment.
Apr 30 2024, 6:13 PM
2024-04-30 18:13:16 (UTC+0)
Comment Actions
Change #1025833 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Add description text for temporary account viewing preference
gerritbot
added a project:
Patch-For-Review
Apr 30 2024, 6:13 PM
2024-04-30 18:13:17 (UTC+0)
gerritbot
added a comment.
Apr 30 2024, 6:22 PM
2024-04-30 18:22:50 (UTC+0)
Comment Actions
Change #1025835 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/WikimediaMessages@master] Use bullet points in the temporary account preference description
Dreamy_Jazz
moved this task from
In Progress
to
Needs Review
on the
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
board.
Apr 30 2024, 6:38 PM
2024-04-30 18:38:57 (UTC+0)
Samwalton9-WMF
added a comment.
May 1 2024, 6:35 AM
2024-05-01 06:35:20 (UTC+0)
Comment Actions
In
T327281#9758124
@Dreamy_Jazz
wrote:
In
T327281#9757499
@Samwalton9-WMF
wrote:
In
T327281#9565295
@Dreamy_Jazz
wrote:
In
T327281#9558369
@PBradley-WMF
wrote:
Design-wise, two thoughts:
the two paras starting "You..." should be shown as list items!
Mock-up for what this looks like:
Has this change been merged? It seems like a clear improvement to me.
No, this has not been merged. I can work on a patch for that.
The HTML specification does not allow bullet points in this area (see
). I had forgot about that when I made the comment above with the mockup. While it worked on Chrome, there is no guarantee it would work on other browsers.
The alternative is to put the text above the checkbox but in the same section as shown below:
I think this looks good - it actually has a more logical flow to me - read this, then agree.
PBradley-WMF
added a comment.
May 1 2024, 7:51 AM
2024-05-01 07:51:09 (UTC+0)
Comment Actions
Ditto
Dreamy_Jazz
added a comment.
May 1 2024, 9:32 AM
2024-05-01 09:32:50 (UTC+0)
Comment Actions
Thanks for the feedback. The mock-up has been written into the two open changes attached to this task which are ready for code review.
gerritbot
added a comment.
May 1 2024, 11:13 AM
2024-05-01 11:13:30 (UTC+0)
Comment Actions
Change #1025833
merged
by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add description text for temporary account viewing preference
ReleaseTaggerBot
added a project:
MW-1.43-notes (1.43.0-wmf.4; 2024-05-07)
May 1 2024, 12:00 PM
2024-05-01 12:00:34 (UTC+0)
gerritbot
added a comment.
May 1 2024, 1:54 PM
2024-05-01 13:54:23 (UTC+0)
Comment Actions
Change #1025835
merged
by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Use bullet points in the temporary account preference description
Maintenance_bot
removed a project:
Patch-For-Review
May 1 2024, 2:30 PM
2024-05-01 14:30:21 (UTC+0)
Dreamy_Jazz
added a comment.
May 1 2024, 2:35 PM
2024-05-01 14:35:00 (UTC+0)
Comment Actions
Suggested QA steps for a local wiki:
Install CheckUser and WikimediaMessages extensions
Add
$wgGroupPermissions['sysop']['checkuser-temporary-account'] = true;
to your
LocalSettings.php
(if it is not already defined)
Log in to an account that has the
sysop
group
Load Special:Preferences
Scroll down to the bottom while on the first tab named User profile
Verify that the section with the
Temporary account IP reveal
heading looks like the following:
Dreamy_Jazz
moved this task from
Needs Review
to
Needs QA
on the
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
board.
May 1 2024, 2:35 PM
2024-05-01 14:35:11 (UTC+0)
Djackson-ctr
subscribed.
May 2 2024, 2:45 AM
2024-05-02 02:45:51 (UTC+0)
Comment Actions
Per the ticket Description, I have verified the new code has been implemented and is functioning and displaying as expected... Good Work
@Dreamy_Jazz
!!!
Djackson-ctr
moved this task from
Needs QA
to
Done
on the
Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May))
board.
May 2 2024, 2:49 AM
2024-05-02 02:49:36 (UTC+0)
Tchanders
closed this task as
Resolved
May 13 2024, 9:26 AM
2024-05-13 09:26:01 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits