⚓ T361400 1.43.0-wmf.6 deployment blockers
Page Menu
Phabricator
Create Task
Maniphest
T361400
1.43.0-wmf.6 deployment blockers
Closed, Resolved
Public
5 Estimated Story Points
Release
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Aklapper
Authored By
thcipriani
Mar 29 2024, 8:42 PM
2024-03-29 20:42:41 (UTC+0)
Tags
Train Deployments
(Backlog)
Release
(Backlog)
Release-Engineering-Team (Yakisfaction)
(Done)
Referenced Files
None
Subscribers
Aklapper
daniel
Ladsgroup
Tgr
thcipriani
Details
Backup Train Conductor
hashar
Release Version
1.43.0-wmf.6
Release Date
May 20 2024, 12:00 AM
2024
week
21
1.43-wmf.6 Changes
wmf/1.43.0-wmf.6
This MediaWiki Train Deployment is scheduled for the week of
Monday, May 20th
Monday May 20th
Tuesday, May 21st
Wednesday, May 22nd
Thursday, May 23rd
Friday
Backports
only.
Branch
wmf.6
and deploy to Group 0 Wikis.
Deploy
wmf.6
to Group 1 Wikis.
Deploy
wmf.6
to all Wikis.
No deployments on fridays
See
for full schedule.
How this works
Any serious bugs affecting
wmf.6
should be added as subtasks beneath this one.
Use
this form
to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the
#wikimedia-operations IRC channel
If you have a risky change in this week's train add a comment to this task using the
Risky patch template
For more info about deployment blockers, see
Holding the train
Related Links
Train status
MediaWiki 1.43/Roadmap
Commits cherry-picked to 1.43.0-wmf.6
Backports vs train deployment
Other Deployments
Previous: 1.43.0-wmf.5
Next: 1.43.0-wmf.7
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
group2 wikis to 1.43.0-wmf.6
operations/mediawiki-config
master
+336
-336
group1 wikis to 1.43.0-wmf.6
operations/mediawiki-config
master
+553
-553
group0 wikis to 1.43.0-wmf.6
operations/mediawiki-config
master
+132
-132
Revert "group0 wikis to 1.43.0-wmf.6"
operations/mediawiki-config
master
+132
-132
group0 wikis to 1.43.0-wmf.6
operations/mediawiki-config
master
+132
-132
testwikis wikis to 1.43.0-wmf.6
operations/mediawiki-config
master
+3
-3
Branch commit for wmf/1.43.0-wmf.6
mediawiki/core
wmf/1.43.0-wmf.6
+1 K
-3
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
Release
Aklapper
T361400
1.43.0-wmf.6 deployment blockers
Resolved
PRODUCTION ERROR
Nikerabbit
T365451
TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
Resolved
PRODUCTION ERROR
matmarex
T365495
TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2446
Mentioned In
T365385: Verify 1.43.0-wmf.6 deployment
T365309: CTT tasks week of 2024-05-17
Mentioned Here
T365451: TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
rECAU8326b0acda7d: Use virtual db domains for CentralAuth
Event Timeline
thcipriani
created this task.
Mar 29 2024, 8:42 PM
2024-03-29 20:42:41 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Mar 29 2024, 8:42 PM
2024-03-29 20:42:41 (UTC+0)
daniel
subscribed.
Edited
May 17 2024, 1:39 PM
2024-05-17 13:39:10 (UTC+0)
Comment Actions
Risky Patch! 🚂🔥
Change
Summary
: Refactoring of the code in img_auth.php, the entry point used to serve unscaled media files on private wikis.
Refactoring complex code that was previously untested
Test plan
Extensive phpunit tests were added.
After deployment to group 0, test that
is
not
accessible without logging into Office Wiki, but
is
accessible when logged in.
Places to monitor
Logstash: mediawiki-errors
Logstash: mediawiki-client-errors
Grafana: mediawiki-errors
Revert plan
: Revert the patch.
Affected wikis
: private wikis, like officewiki
IRC contact
: dues (Daniel Kinzler) UTC+2, AaronSchulz (Aaron Schulz) UTC-7
UBN Task Projects/tags
MW-Interfaces-Team
Would you like to backport this change rather than ride the train?
: Ride the train
ihurbain
mentioned this in
T365309: CTT tasks week of 2024-05-17
May 18 2024, 6:52 AM
2024-05-18 06:52:58 (UTC+0)
Jdlrobson
mentioned this in
T365385: Verify 1.43.0-wmf.6 deployment
May 20 2024, 5:39 PM
2024-05-20 17:39:32 (UTC+0)
Tgr
added a parent task:
T348486: Migrate CentralAuth to use a virtual database domain
May 20 2024, 10:07 PM
2024-05-20 22:07:01 (UTC+0)
Tgr
subscribed.
May 20 2024, 10:10 PM
2024-05-20 22:10:49 (UTC+0)
Comment Actions
rECAU8326b0acda7d: Use virtual db domains for CentralAuth
will probably break SUL login while it's only partially deployed. Proposed fix is
, needs to be merged & backported before the group0 train.
thcipriani
assigned this task to
Aklapper
May 20 2024, 10:49 PM
2024-05-20 22:49:53 (UTC+0)
thcipriani
triaged this task as
Medium
priority.
thcipriani
updated Other Assignee, added:
hashar
thcipriani
set the point value for this task to
thcipriani
added a project:
Release-Engineering-Team (Yakisfaction)
Jdlrobson
added a subtask:
T365409: Clicking Echo icon breaks Echo notification icon display
May 20 2024, 11:46 PM
2024-05-20 23:46:22 (UTC+0)
gerritbot
added a comment.
May 21 2024, 1:07 AM
2024-05-21 01:07:41 (UTC+0)
Comment Actions
Change #1033393 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):
[mediawiki/core@wmf/1.43.0-wmf.6] Branch commit for wmf/1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 21 2024, 1:07 AM
2024-05-21 01:07:42 (UTC+0)
gerritbot
added a comment.
May 21 2024, 1:29 AM
2024-05-21 01:29:24 (UTC+0)
Comment Actions
Change #1033393
merged
by jenkins-bot:
[mediawiki/core@wmf/1.43.0-wmf.6] Branch commit for wmf/1.43.0-wmf.6
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 1:31 AM
2024-05-21 01:31:20 (UTC+0)
gerritbot
added a comment.
May 21 2024, 3:01 AM
2024-05-21 03:01:40 (UTC+0)
Comment Actions
Change #1034206 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):
[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 21 2024, 3:01 AM
2024-05-21 03:01:41 (UTC+0)
Comment Actions
Change #1034206
merged
by jenkins-bot:
[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.6
Stashbot
added a comment.
May 21 2024, 3:02 AM
2024-05-21 03:02:55 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-21T03:02:54Z]
T361400
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 3:31 AM
2024-05-21 03:31:27 (UTC+0)
Stashbot
added a comment.
May 21 2024, 4:01 AM
2024-05-21 04:01:48 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-21T04:01:46Z]
T361400
(duration: 58m 51s)
Aklapper
removed a parent task:
T348486: Migrate CentralAuth to use a virtual database domain
May 21 2024, 7:34 AM
2024-05-21 07:34:34 (UTC+0)
Aklapper
added a subtask:
T348486: Migrate CentralAuth to use a virtual database domain
Aklapper
moved this task from
Backlog
to
Ready
on the
Release-Engineering-Team (Yakisfaction)
board.
May 21 2024, 8:18 AM
2024-05-21 08:18:54 (UTC+0)
Comment Actions
Patches supposed to handle the two current subtasks (
T365409
T348486
) have been merged so we're ready to proceed for group0.
Ladsgroup
subscribed.
May 21 2024, 9:02 AM
2024-05-21 09:02:03 (UTC+0)
gerritbot
added a comment.
May 21 2024, 9:24 AM
2024-05-21 09:24:41 (UTC+0)
Comment Actions
Change #1034441 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):
[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 21 2024, 9:24 AM
2024-05-21 09:24:42 (UTC+0)
Comment Actions
Change #1034441
merged
by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.6
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 9:31 AM
2024-05-21 09:31:36 (UTC+0)
Stashbot
added a comment.
May 21 2024, 9:41 AM
2024-05-21 09:41:22 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-21T09:41:21Z]
T361400
Aklapper
added a subtask:
T365451: TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
May 21 2024, 9:51 AM
2024-05-21 09:51:38 (UTC+0)
Comment Actions
In
T361400#9808732
@daniel
wrote:
Risky Patch! 🚂🔥
After deployment to group 0, test that
is
not
accessible without logging into Office Wiki, but
is
accessible when logged in.
Tested now that deployed wmf.6 to group0 and still behaves as expected.
Aklapper
added a comment.
May 21 2024, 10:28 AM
2024-05-21 10:28:04 (UTC+0)
Comment Actions
Reverted group0 back to 1.43.0-wmf.5 because
T365451
. Nikerabbit said they'd take a look soon.
gerritbot
added a comment.
May 21 2024, 10:31 AM
2024-05-21 10:31:44 (UTC+0)
Comment Actions
Change #1034454 had a related patch set uploaded (by Hashar; author: Aklapper):
[operations/mediawiki-config@master] Revert "group0 wikis to 1.43.0-wmf.6"
gerritbot
added a project:
Patch-For-Review
May 21 2024, 10:31 AM
2024-05-21 10:31:45 (UTC+0)
Comment Actions
Change #1034454
merged
by jenkins-bot:
[operations/mediawiki-config@master] Revert "group0 wikis to 1.43.0-wmf.6"
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 11:31 AM
2024-05-21 11:31:17 (UTC+0)
Jdforrester-WMF
removed a subtask:
T365409: Clicking Echo icon breaks Echo notification icon display
May 21 2024, 1:54 PM
2024-05-21 13:54:03 (UTC+0)
Tgr
removed a subtask:
T348486: Migrate CentralAuth to use a virtual database domain
May 21 2024, 2:05 PM
2024-05-21 14:05:34 (UTC+0)
Aklapper
moved this task from
Ready
to
In progress
on the
Release-Engineering-Team (Yakisfaction)
board.
May 21 2024, 2:44 PM
2024-05-21 14:44:23 (UTC+0)
gerritbot
added a comment.
May 21 2024, 2:47 PM
2024-05-21 14:47:50 (UTC+0)
Comment Actions
Change #1034504 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):
[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 21 2024, 2:47 PM
2024-05-21 14:47:52 (UTC+0)
Comment Actions
Change #1034504
merged
by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.6
Stashbot
added a comment.
May 21 2024, 3:04 PM
2024-05-21 15:04:02 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-21T15:04:02Z]
T361400
Aklapper
added a subtask:
T365495: TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2446
May 21 2024, 3:20 PM
2024-05-21 15:20:53 (UTC+0)
Aklapper
closed subtask
T365451: TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
as
Resolved
May 21 2024, 3:24 PM
2024-05-21 15:24:09 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
May 21 2024, 3:32 PM
2024-05-21 15:32:42 (UTC+0)
hashar
closed subtask
T365495: TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2446
as
Resolved
May 22 2024, 8:04 AM
2024-05-22 08:04:13 (UTC+0)
gerritbot
added a comment.
May 22 2024, 8:25 AM
2024-05-22 08:25:25 (UTC+0)
Comment Actions
Change #1034846 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):
[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 22 2024, 8:25 AM
2024-05-22 08:25:26 (UTC+0)
Comment Actions
Change #1034846
merged
by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.6
Maintenance_bot
removed a project:
Patch-For-Review
May 22 2024, 8:31 AM
2024-05-22 08:31:13 (UTC+0)
Stashbot
added a comment.
May 22 2024, 8:41 AM
2024-05-22 08:41:52 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-22T08:41:51Z]
T361400
matmarex
added a subtask:
T365408: [Subtask[Regression] Vector 2022 uses wrong font size on talk pages
May 22 2024, 3:08 PM
2024-05-22 15:08:33 (UTC+0)
Jdlrobson
removed a subtask:
T365408: [Subtask[Regression] Vector 2022 uses wrong font size on talk pages
May 22 2024, 10:04 PM
2024-05-22 22:04:08 (UTC+0)
gerritbot
added a comment.
May 23 2024, 8:16 AM
2024-05-23 08:16:06 (UTC+0)
Comment Actions
Change #1035320 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):
[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.6
gerritbot
added a project:
Patch-For-Review
May 23 2024, 8:16 AM
2024-05-23 08:16:07 (UTC+0)
Comment Actions
Change #1035320
merged
by jenkins-bot:
[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.6
Maintenance_bot
removed a project:
Patch-For-Review
May 23 2024, 8:31 AM
2024-05-23 08:31:01 (UTC+0)
Stashbot
added a comment.
May 23 2024, 8:31 AM
2024-05-23 08:31:40 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-05-23T08:31:40Z]
T361400
Aklapper
closed this task as
Resolved
May 23 2024, 1:29 PM
2024-05-23 13:29:18 (UTC+0)
Aklapper
moved this task from
In progress
to
Done
on the
Release-Engineering-Team (Yakisfaction)
board.
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits
US