⚓ T377829 Hide auto-promotions into the local 'checkuser-temporary-account-viewer' group in Special:RecentChanges
Page Menu
Phabricator
Create Task
Maniphest
T377829
Hide auto-promotions into the local 'checkuser-temporary-account-viewer' group in Special:RecentChanges
Closed, Resolved
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
mszabo
Authored By
Dreamy_Jazz
Oct 22 2024, 11:30 AM
2024-10-22 11:30:21 (UTC+0)
Tags
CheckUser
(Temporary account IP reveal)
Trust and Safety Product Team
(Inbox)
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
(Done)
MW-1.44-notes (1.44.0-wmf.2; 2024-11-05)
Temporary accounts (Create/update essential tools/anti-abuse management)
(Backlog)
Referenced Files
None
Subscribers
Aklapper
dom_walden
Dreamy_Jazz
Niharika
Tchanders
Titore
Description
WMF stewards have expressed that they would prefer that the auto-promotions into the
checkuser-temporary-account-viewer
group on
metawiki
be hidden from
Special:RecentChanges
. This is because there are currently a lot of of these entries being generated.
We should hide the auto-promotion into this group to avoid spamming recent change feeds.
Acceptance criteria
Hide the auto-promotion into the
checkuser-temporary-account-viewer
group from
Special:RecentChanges
on WMF wikis
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Exclude temp account viewer autopromotions from RC
operations/mediawiki-config
master
+3
-0
user: Allow excluding autopromotions into select groups from RC
mediawiki/core
master
+126
-1
Customize query in gerrit
Related Objects
Mentions
Mentioned Here
rMWf0dfd5e727ea: Localisation updates from https://translatewiki.net.
Event Timeline
Dreamy_Jazz
created this task.
Oct 22 2024, 11:30 AM
2024-10-22 11:30:21 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Oct 22 2024, 11:30 AM
2024-10-22 11:30:21 (UTC+0)
Tchanders
subscribed.
Oct 22 2024, 12:01 PM
2024-10-22 12:01:44 (UTC+0)
Comment Actions
@Dreamy_Jazz
Just to clarify, does this mean that we should hide these autopromotion logs everywhere, and not just temporarily now for meta?
Dreamy_Jazz
added a comment.
Edited
Oct 22 2024, 12:06 PM
2024-10-22 12:06:05 (UTC+0)
Comment Actions
In
T377829#10249905
@Tchanders
wrote:
@Dreamy_Jazz
Just to clarify, does this mean that we should hide these autopromotion logs everywhere, and not just temporarily now for meta?
I believe that we should hide these everywhere and not just temporarily, based on feedback that was received. If a wiki wants to undo this, we probably would implement the hiding via config so we could undo it for just that wiki.
Niharika
subscribed.
Oct 23 2024, 12:09 PM
2024-10-23 12:09:46 (UTC+0)
Comment Actions
Seems fine to me. I don't have any concerns about doing this.
kostajh
moved this task from
Priority Backlog
to
Ready
on the
Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18))
board.
Oct 28 2024, 10:37 AM
2024-10-28 10:37:36 (UTC+0)
kostajh
edited projects, added
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
; removed
Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18))
Oct 28 2024, 11:03 AM
2024-10-28 11:03:19 (UTC+0)
kostajh
moved this task from
Priority Backlog
to
Ready
on the
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
board.
mszabo
changed the task status from
Open
to
In Progress
Oct 29 2024, 11:44 AM
2024-10-29 11:44:32 (UTC+0)
mszabo
claimed this task.
Titore
subscribed.
Oct 29 2024, 5:20 PM
2024-10-29 17:20:44 (UTC+0)
gerritbot
added a comment.
Oct 29 2024, 10:57 PM
2024-10-29 22:57:04 (UTC+0)
Comment Actions
Change #1084262 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):
[mediawiki/core@master] user: Allow excluding autopromotions into select groups from RC
gerritbot
added a project:
Patch-For-Review
Oct 29 2024, 10:57 PM
2024-10-29 22:57:05 (UTC+0)
mszabo
moved this task from
Ready
to
Needs review
on the
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
board.
Oct 29 2024, 10:57 PM
2024-10-29 22:57:34 (UTC+0)
gerritbot
added a comment.
Oct 31 2024, 1:08 PM
2024-10-31 13:08:10 (UTC+0)
Comment Actions
Change #1084262
merged
by jenkins-bot:
[mediawiki/core@master] user: Allow excluding autopromotions into select groups from RC
mszabo
added a comment.
Oct 31 2024, 1:11 PM
2024-10-31 13:11:48 (UTC+0)
Comment Actions
Test Plan:
Setup some user groups with an associated
$wgAutopromoteOnce
condition.
Set
$wgAutopromoteRCExcludedGroups
to include at least one of these user groups.
Set
$wgAutopromoteOnceLogInRC
to
true
Upon evaluating one-shot autopromotion, if all new autopromote groups are part of
$wgAutopromoteRCExcludedGroups
, no RC entry should be created as a result of the autopromotion, but the change should still be recorded in the logging table.
In every other scenario, an RC entry should be published as well.
mszabo
moved this task from
Needs review
to
Needs QA
on the
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
board.
Oct 31 2024, 1:12 PM
2024-10-31 13:12:01 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Oct 31 2024, 1:31 PM
2024-10-31 13:31:05 (UTC+0)
ReleaseTaggerBot
added a project:
MW-1.44-notes (1.44.0-wmf.2; 2024-11-05)
Oct 31 2024, 2:00 PM
2024-10-31 14:00:42 (UTC+0)
dom_walden
subscribed.
Nov 1 2024, 11:32 AM
2024-11-01 11:32:38 (UTC+0)
Comment Actions
@mszabo
I have in my LocalSettings.php:
$wgAutopromoteOnce = [
'onEdit' => [
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
$wgAutopromoteRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
$wgAutopromoteOnceLogInRC = true;
As a new user, I make an edit. In Special:RecentChanges, I see
I have tried looking at the logs but I cannot work out why this is happening.
Dreamy_Jazz
added a comment.
Nov 1 2024, 11:36 AM
2024-11-01 11:36:27 (UTC+0)
Comment Actions
In
T377829#10283873
@dom_walden
wrote:
@mszabo
I have in my LocalSettings.php:
$wgAutopromoteOnce = [
'onEdit' => [
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
$wgAutopromoteRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
$wgAutopromoteOnceLogInRC = true;
As a new user, I make an edit. In Special:RecentChanges, I see
I have tried looking at the logs but I cannot work out why this is happening.
It seems that the config name was typed incorrectly in the comment above. It is named
$wgAutopromoteOnceRCExcludedGroups
mszabo
added a comment.
Nov 1 2024, 12:21 PM
2024-11-01 12:21:40 (UTC+0)
Comment Actions
In
T377829#10283878
@Dreamy_Jazz
wrote:
In
T377829#10283873
@dom_walden
wrote:
@mszabo
I have in my LocalSettings.php:
$wgAutopromoteOnce = [
'onEdit' => [
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
$wgAutopromoteRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
$wgAutopromoteOnceLogInRC = true;
As a new user, I make an edit. In Special:RecentChanges, I see
I have tried looking at the logs but I cannot work out why this is happening.
It seems that the config name was typed incorrectly in the comment above. It is named
$wgAutopromoteOnceRCExcludedGroups
Yeah, that's right. Sorry about the confusion!
dom_walden
moved this task from
Needs QA
to
Done
on the
Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15)
board.
Nov 1 2024, 1:10 PM
2024-11-01 13:10:01 (UTC+0)
Comment Actions
Ah, right, thanks!
With:
$wgAutopromoteOnce = [
'onEdit' => [
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
I don't see an RC entry when I set:
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
or
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer', 'captain' ];
With:
$wgAutopromoteOnce = [
'onEdit' => [
'captain' => [ APCOND_EDITCOUNT, 0 ],
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
I don't see an RC entry when I set:
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer', 'captain' ];
I do see an RC entry when I set
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
I believe that is what we want based on
T377829#10280740
Test environment:
local docker MediaWiki 1.44.0-alpha (
f0dfd5e
) 07:04, 1 November 2024.
mszabo
added a comment.
Nov 1 2024, 1:31 PM
2024-11-01 13:31:13 (UTC+0)
Comment Actions
In
T377829#10284012
@dom_walden
wrote:
Ah, right, thanks!
With:
$wgAutopromoteOnce = [
'onEdit' => [
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
I don't see an RC entry when I set:
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
or
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer', 'captain' ];
With:
$wgAutopromoteOnce = [
'onEdit' => [
'captain' => [ APCOND_EDITCOUNT, 0 ],
'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
];
I don't see an RC entry when I set:
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer', 'captain' ];
I do see an RC entry when I set
$wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
I believe that is what we want based on
T377829#10280740
Test environment:
local docker MediaWiki 1.44.0-alpha (
f0dfd5e
) 07:04, 1 November 2024.
Yeah, we still want the RC entry to be generated if the one-shot autopromotion caused some other groups to be added that are not explicitly marked for exclusion from RC. Looks good!
Dreamy_Jazz
added a comment.
Nov 1 2024, 1:49 PM
2024-11-01 13:49:21 (UTC+0)
Comment Actions
I guess what is left is to update site config to hide the
checkuser-temporary-account-viewer
group.
gerritbot
added a comment.
Nov 1 2024, 2:29 PM
2024-11-01 14:29:43 (UTC+0)
Comment Actions
Change #1085593 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):
[operations/mediawiki-config@master] Exclude temp account viewer autopromotions from RC
gerritbot
added a project:
Patch-For-Review
Nov 1 2024, 2:29 PM
2024-11-01 14:29:44 (UTC+0)
Tchanders
edited projects, added
Temporary accounts (Create/update essential tools/anti-abuse management)
; removed
Temporary accounts
Nov 7 2024, 5:48 PM
2024-11-07 17:48:01 (UTC+0)
Dreamy_Jazz
moved this task from
Inbox
to
Temporary account IP reveal
on the
CheckUser
board.
Nov 11 2024, 10:49 AM
2024-11-11 10:49:09 (UTC+0)
gerritbot
added a comment.
Nov 11 2024, 1:02 PM
2024-11-11 13:02:50 (UTC+0)
Comment Actions
Change #1085593
merged
by jenkins-bot:
[operations/mediawiki-config@master] Exclude temp account viewer autopromotions from RC
Stashbot
added a comment.
Nov 11 2024, 1:03 PM
2024-11-11 13:03:12 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-11-11T13:03:11Z]
T377829
)]]
Stashbot
added a comment.
Nov 11 2024, 1:05 PM
2024-11-11 13:05:41 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-11-11T13:05:40Z]
T377829
)]] synced to the testservers (
Stashbot
added a comment.
Nov 11 2024, 1:10 PM
2024-11-11 13:10:19 (UTC+0)
Comment Actions
Mentioned in SAL (#wikimedia-operations)
[2024-11-11T13:10:19Z]
T377829
)]] (duration: 07m 07s)
Dreamy_Jazz
closed this task as
Resolved
Nov 11 2024, 1:18 PM
2024-11-11 13:18:25 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Nov 11 2024, 1:30 PM
2024-11-11 13:30:23 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits
US