⚓ T392333 Rename EditResult::isNullEdit()
Page Menu
Phabricator
Create Task
Maniphest
T392333
Rename EditResult::isNullEdit()
Open, Medium
Public
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
daniel
Authored By
daniel
Apr 19 2025, 10:34 AM
2025-04-19 10:34:05 (UTC+0)
Tags
MediaWiki-Page-editing
(Backlog)
MW-1.46-notes (1.46.0-wmf.17; 2026-02-24)
MW-Interfaces-Team
(Backlog)
Referenced Files
None
Subscribers
aaron
Aklapper
daniel
Novem_Linguae
Pppery
Description
The semantics of
EditResult::isNullEdit()
do not match the definition of a null edit given in
. It will also return true for null (dummy) revisions (see
). Indeed covering dummy revisions appears to be the original intent.
The method is
used fairly widely in extensions and skins
, and it's not immediately clear what the expected semantics are in each use case. To avoid further confusion, EditResult should use the same terminology as
PageRevisionUpdatedEvent
changedLatestRevisionId()
returns true for null edits but not for dummy revisions.
isEffectiveContentChange()
returns false for both null edits and dummy revisions.
isNominalContentChange()
returns false for dummy revisions but true for null edits.
The
isNullEdit
method should be deprecated and replaced by the three methods above. Ideally, callers would use
PageRevisionUpdatedEvent
for this information, but that requires all handlers for the
PageSaveCompleteHook
to be converted to listeners for
PageRevisionUpdatedEvent
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
Storage: Clarify semantics of EditResult::isNullEdit
mediawiki/core
master
+84
-17
Customize query in gerrit
Event Timeline
daniel
created this task.
Apr 19 2025, 10:34 AM
2025-04-19 10:34:05 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Apr 19 2025, 10:34 AM
2025-04-19 10:34:05 (UTC+0)
daniel
updated the task description.
(Show Details)
Apr 19 2025, 10:41 AM
2025-04-19 10:41:00 (UTC+0)
gerritbot
added a comment.
Apr 19 2025, 10:47 AM
2025-04-19 10:47:22 (UTC+0)
Comment Actions
Change #1137508 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):
[mediawiki/core@master] Storage: Clarify semantics of EditResult::isNullEdit
gerritbot
added a project:
Patch-For-Review
Apr 19 2025, 10:47 AM
2025-04-19 10:47:23 (UTC+0)
Bugreporter2
updated the task description.
(Show Details)
Apr 19 2025, 1:46 PM
2025-04-19 13:46:33 (UTC+0)
Novem_Linguae
subscribed.
Apr 21 2025, 12:18 PM
2025-04-21 12:18:08 (UTC+0)
Pppery
edited projects, added
MediaWiki-Page-editing
; removed
MediaWiki-General
Apr 22 2025, 8:52 PM
2025-04-22 20:52:12 (UTC+0)
daniel
moved this task from
Incoming (Needs Triage)
to
To Refine
on the
MW-Interfaces-Team
board.
May 7 2025, 5:02 PM
2025-05-07 17:02:45 (UTC+0)
HCoplin-WMF
moved this task from
To Refine
to
Backlog
on the
MW-Interfaces-Team
board.
Aug 21 2025, 2:24 PM
2025-08-21 14:24:40 (UTC+0)
Atieno
assigned this task to
daniel
Nov 11 2025, 2:21 PM
2025-11-11 14:21:57 (UTC+0)
Atieno
moved this task from
Backlog
to
MWI-Sprint-22 (2025-11-04 to 2025-11-18)
on the
MW-Interfaces-Team
board.
Atieno
edited projects, added
MW-Interfaces-Team (MWI-Sprint-22 (2025-11-04 to 2025-11-18))
; removed
MW-Interfaces-Team
Atieno
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-22 (2025-11-04 to 2025-11-18))
board.
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-23 (2025-11-18 to 2025-12-02))
; removed
MW-Interfaces-Team (MWI-Sprint-22 (2025-11-04 to 2025-11-18))
Nov 18 2025, 3:58 PM
2025-11-18 15:58:15 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-23 (2025-11-18 to 2025-12-02))
board.
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-24 (2025-12-02 to 2025-12-24))
; removed
MW-Interfaces-Team (MWI-Sprint-23 (2025-11-18 to 2025-12-02))
Dec 2 2025, 4:12 PM
2025-12-02 16:12:19 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-24 (2025-12-02 to 2025-12-24))
board.
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-25 (2026-01-13 to 2026-01-27))
; removed
MW-Interfaces-Team (MWI-Sprint-24 (2025-12-02 to 2025-12-24))
Jan 13 2026, 4:09 PM
2026-01-13 16:09:55 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-25 (2026-01-13 to 2026-01-27))
board.
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-26 (2026-01-27 to 2026-02-10))
; removed
MW-Interfaces-Team (MWI-Sprint-25 (2026-01-13 to 2026-01-27))
Jan 27 2026, 4:12 PM
2026-01-27 16:12:09 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-26 (2026-01-27 to 2026-02-10))
board.
OWresch-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-27 (2026-02-10 to 2026-02-24))
; removed
MW-Interfaces-Team (MWI-Sprint-26 (2026-01-27 to 2026-02-10))
Feb 11 2026, 9:59 AM
2026-02-11 09:59:00 (UTC+0)
OWresch-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-27 (2026-02-10 to 2026-02-24))
board.
gerritbot
added a comment.
Feb 20 2026, 2:37 AM
2026-02-20 02:37:33 (UTC+0)
Comment Actions
Change #1137508
merged
by jenkins-bot:
[mediawiki/core@master] Storage: Clarify semantics of EditResult::isNullEdit
ReleaseTaggerBot
added a project:
MW-1.46-notes (1.46.0-wmf.17; 2026-02-24)
Feb 20 2026, 3:00 AM
2026-02-20 03:00:35 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Feb 20 2026, 3:30 AM
2026-02-20 03:30:41 (UTC+0)
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-28 (2026-02-24 to 2026-03-10))
; removed
MW-Interfaces-Team (MWI-Sprint-27 (2026-02-10 to 2026-02-24))
Feb 26 2026, 6:22 PM
2026-02-26 18:22:37 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-28 (2026-02-24 to 2026-03-10))
board.
HCoplin-WMF
edited projects, added
MW-Interfaces-Team (MWI-Sprint-29 (2026-03-10 to 2026-03-24))
; removed
MW-Interfaces-Team (MWI-Sprint-28 (2026-02-24 to 2026-03-10))
Mar 10 2026, 3:44 PM
2026-03-10 15:44:02 (UTC+0)
HCoplin-WMF
moved this task from
Committed
to
Code Review
on the
MW-Interfaces-Team (MWI-Sprint-29 (2026-03-10 to 2026-03-24))
board.
aaron
edited projects, added
MW-Interfaces-Team
; removed
MW-Interfaces-Team (MWI-Sprint-29 (2026-03-10 to 2026-03-24))
Mar 12 2026, 4:23 PM
2026-03-12 16:23:35 (UTC+0)
aaron
triaged this task as
Medium
priority.
Mar 17 2026, 5:34 AM
2026-03-17 05:34:18 (UTC+0)
aaron
moved this task from
Incoming (Needs Triage)
to
Backlog
on the
MW-Interfaces-Team
board.
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits