⚓ T397668 UserInfoCard: Add/remove to watchlist message should use gender settings of the target user

⚓ T397668 UserInfoCard: Add/remove to watchlist message should use gender settings of the target user
Page Menu
Phabricator
Create Task
Maniphest
T397668
UserInfoCard: Add/remove to watchlist message should use gender settings of the target user
Closed, Resolved
Public
BUG REPORT
Actions
Edit Task
Edit Related Tasks...
Create Subtask
Edit Parent Tasks
Edit Subtasks
Merge Duplicates In
Close As Duplicate
Edit Related Objects...
Edit Commits
Edit Mocks
Mute Notifications
Protect as security issue
Assigned To
Mimurawil
Authored By
KColeman-WMF
Jun 23 2025, 10:22 PM
2025-06-23 22:22:56 (UTC+0)
Tags
CheckUser-UserInfoCard
(Triaged)
Trust and Safety Product Team
(Inbox)
Gender-Support
Voice & Tone
(Backlog)
MW-1.45-notes (1.45.0-wmf.8; 2025-07-01)
Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25))
(Done)
OKR-Work
(Backlog)
Referenced Files
F63415461: image.png
Jul 8 2025, 4:02 AM
2025-07-08 04:02:20 (UTC+0)
F63415434: image.png
Jul 8 2025, 4:02 AM
2025-07-08 04:02:20 (UTC+0)
F62768261: image.png
Jul 1 2025, 8:47 PM
2025-07-01 20:47:32 (UTC+0)
F62768256: image.png
Jul 1 2025, 8:47 PM
2025-07-01 20:47:32 (UTC+0)
F62449943: 2025-06-24 13-36-23.mov
Jun 24 2025, 8:40 PM
2025-06-24 20:40:37 (UTC+0)
F62437323: image.png
Jun 23 2025, 10:22 PM
2025-06-23 22:22:56 (UTC+0)
F62437308: image.png
Jun 23 2025, 10:22 PM
2025-06-23 22:22:56 (UTC+0)
Subscribers
Aklapper
Djackson-ctr
JJMC89
KColeman-WMF
kostajh
Tacsipacsi
Description
What happens?
When adding or removing a user from watchlist:
The message says
{Username} and its discussion page...
What should have happened instead?
When adding or removing a user from watchlist:
The message should say
{Username} and their discussion page...
Software version
/ Desktop
Details
Related Changes in Gerrit:
Subject
Repo
Branch
Lines +/-
useWatchList.js: use page title instead of username for i18n messages
mediawiki/extensions/CheckUser
master
+5
-5
Customize query in gerrit
Related Objects
Search...
Task Graph
Mentions
Status
Subtype
Assigned
Task
Resolved
KColeman-WMF
T384725
[Epic] WE4.2.18 UserInfoCard experiment for assisting patrollers and moderators
Resolved
BUG REPORT
Mimurawil
T397668
UserInfoCard: Add/remove to watchlist message should use gender settings of the target user
Mentioned Here
rMW103cda978fea: Merge "cleanupTitles: Add support for file read new"
Event Timeline
KColeman-WMF
created this task.
Jun 23 2025, 10:22 PM
2025-06-23 22:22:56 (UTC+0)
Restricted Application
added a subscriber:
Aklapper
View Herald Transcript
Jun 23 2025, 10:22 PM
2025-06-23 22:22:56 (UTC+0)
KColeman-WMF
added a parent task:
T384725: [Epic] WE4.2.18 UserInfoCard experiment for assisting patrollers and moderators
Jun 23 2025, 10:23 PM
2025-06-23 22:23:37 (UTC+0)
JJMC89
subscribed.
Jun 23 2025, 10:38 PM
2025-06-23 22:38:06 (UTC+0)
Comment Actions
Instead of
their
, it should use the target user's grammatical gender from preferences, i.e.,
{{GENDER:$1|his|her|their}}
KColeman-WMF
added a comment.
Jun 23 2025, 10:41 PM
2025-06-23 22:41:05 (UTC+0)
Comment Actions
In
T397668#10940381
@JJMC89
wrote:
Instead of
their
, it should use the target user's grammatical gender from preferences, i.e.,
{{GENDER:$1|his|her|their}}
Thank you for highlighting that!
Reedy
renamed this task from
UserInfoCard: Add/remove to watchlist message should say "their"
to
UserInfoCard: Add/remove to watchlist message should use pronoun settings of the target user
Jun 24 2025, 1:09 AM
2025-06-24 01:09:42 (UTC+0)
Reedy
renamed this task from
UserInfoCard: Add/remove to watchlist message should use pronoun settings of the target user
to
UserInfoCard: Add/remove to watchlist message should use gender settings of the target user
Reedy
added projects:
Gender-Support
Voice & Tone
kostajh
assigned this task to
Mimurawil
Jun 24 2025, 6:27 AM
2025-06-24 06:27:49 (UTC+0)
Tacsipacsi
subscribed.
Jun 24 2025, 2:00 PM
2025-06-24 14:00:54 (UTC+0)
Comment Actions
What should have happened instead?
[…]
The message should say
{Username} and their discussion page...
No, the message should say
"User:{Username}" and its discussion page…
. The message is
addedwatchtext
whose documentation
clearly says that the parameter is a
page title
, not a
user name
. For example, if I translate back the Hungarian translation, I get roughly
The page
"$1" and its talk page…
; of the languages I more or less understand, many more do the same, including French, Czech, Bavarian, Icelandic or Latin. These translations don’t work without the namespace name, adding gender support won’t fix them. (Another possibility is using a custom message, although that would mean having to retranslate the message in all languages.)
gerritbot
added a comment.
Jun 24 2025, 7:22 PM
2025-06-24 19:22:36 (UTC+0)
Comment Actions
Change #1163452 had a related patch set uploaded (by Mimurawil; author: Mimurawil):
[mediawiki/extensions/CheckUser@master] useWatchList.js: use page title instead of username for i18n messages
gerritbot
added a project:
Patch-For-Review
Jun 24 2025, 7:22 PM
2025-06-24 19:22:37 (UTC+0)
KColeman-WMF
added a comment.
Jun 24 2025, 7:57 PM
2025-06-24 19:57:15 (UTC+0)
Comment Actions
Given the above, I propose we change the wording of the message to say:
The user page "{Username}" has been added to your watchlist.
The user page "{Username}" has been removed from your watchlist.
Mimurawil
added a comment.
Jun 24 2025, 8:40 PM
2025-06-24 20:40:37 (UTC+0)
Comment Actions
We are currently using the core messages
addedwatchtext
and
removedwatchtext
, which are the same message keys when the user manually adds a page to their watchlist.
2025-06-24 13-36-23.mov
488 KB
For these menu actions, should we create a custom message for CheckUser?
Tacsipacsi
added a comment.
Jun 24 2025, 8:47 PM
2025-06-24 20:47:07 (UTC+0)
Comment Actions
In
T397668#10944573
@KColeman-WMF
wrote:
Given the above, I propose we change the wording of the message to say:
The user page "{Username}" has been added to your watchlist.
The user page "{Username}" has been removed from your watchlist.
Again, that’d require a custom message. In
addedwatchtext
, the parameter should be a prefixed page title. This message is meant to be used with pages in any namespace, and the only way to handle pages in arbitrary namespaces without incomprehensibly complicated message source text is using the prefixed page title.
Also, your suggestion leaves out the “its talk page” part (because of which this task was created in the first place), but I think it’s pretty important – as a patroller, I’m more interested in what messages the user gets (i.e. the talk page) than in what they write about themself (i.e. the user page).
Mimurawil
changed the task status from
Open
to
In Progress
Jun 24 2025, 9:02 PM
2025-06-24 21:02:54 (UTC+0)
KColeman-WMF
added a comment.
Jun 24 2025, 9:58 PM
2025-06-24 21:58:21 (UTC+0)
Comment Actions
In
T397668#10944871
@Tacsipacsi
wrote:
Also, your suggestion leaves out the “its talk page” part (because of which this task was created in the first place), but I think it’s pretty important – as a patroller, I’m more interested in what messages the user gets (i.e. the talk page) than in what they write about themself (i.e. the user page).
Thanks for noting that! If we created a custom message, would the following text make sense?
The discussion page for user "JohnDoe" has been added to your watchlist.
Or would it need to say
The discussion page for "User:JohnDoe" has been added to your watchlist.
kostajh
subscribed.
Jun 25 2025, 6:33 AM
2025-06-25 06:33:49 (UTC+0)
Comment Actions
In
T397668#10945148
@KColeman-WMF
wrote:
In
T397668#10944871
@Tacsipacsi
wrote:
Also, your suggestion leaves out the “its talk page” part (because of which this task was created in the first place), but I think it’s pretty important – as a patroller, I’m more interested in what messages the user gets (i.e. the talk page) than in what they write about themself (i.e. the user page).
Thanks for noting that! If we created a custom message, would the following text make sense?
The discussion page for user "JohnDoe" has been added to your watchlist.
Or would it need to say
The discussion page for "User:JohnDoe" has been added to your watchlist.
I'd avoid adding a new message, both because of translator burden and also for consistency with the existing message used elsewhere in MediaWiki UI when adding a page (and its talk page) to the watchlist.
kostajh
moved this task from
Priority Backlog
to
Needs QA
on the
Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4))
board.
Jun 25 2025, 6:33 AM
2025-06-25 06:33:57 (UTC+0)
gerritbot
added a comment.
Jun 25 2025, 6:51 AM
2025-06-25 06:51:34 (UTC+0)
Comment Actions
Change #1163452
merged
by jenkins-bot:
[mediawiki/extensions/CheckUser@master] useWatchList.js: use page title instead of username for i18n messages
ReleaseTaggerBot
added a project:
MW-1.45-notes (1.45.0-wmf.8; 2025-07-01)
Jun 25 2025, 7:00 AM
2025-06-25 07:00:59 (UTC+0)
Maintenance_bot
removed a project:
Patch-For-Review
Jun 25 2025, 7:30 AM
2025-06-25 07:30:26 (UTC+0)
Tacsipacsi
added a comment.
Jun 25 2025, 9:02 AM
2025-06-25 09:02:19 (UTC+0)
Comment Actions
In
T397668#10945148
@KColeman-WMF
wrote:
Thanks for noting that! If we created a custom message, would the following text make sense?
The discussion page for user "JohnDoe" has been added to your watchlist.
Or would it need to say
The discussion page for "User:JohnDoe" has been added to your watchlist.
If
it was a separate message, I’d write
The user page "{Username}" and its discussion page has been (added to/removed from) your watchlist.
, but I agree with
@kostajh
that defining a separate message is probably not worth it.
Djackson-ctr
subscribed.
Edited
Jul 1 2025, 8:47 PM
2025-07-01 20:47:32 (UTC+0)
Comment Actions
@KColeman-WMF
I am currently testing this ticket on test.wikpedia.org with release of MediaWiki 1.45.0-wmf.8 (
103cda9
When I look at the ticket Description, it says that
What should have happened instead when adding or removing a user from watchlist?
The message should say
{Username} and their discussion page...
But during my testing its saying:
{Username} and its discussion page...
So what exactly should the adding/removing messages say?
Tacsipacsi
added a comment.
Jul 2 2025, 8:34 AM
2025-07-02 08:34:55 (UTC+0)
Comment Actions
The description is outdated, the final decision (at least for now) was
"User:{Username}" and its discussion page...
. However, what you see doesn’t match that either. But the colors are also different, and
Gmina Milejewo
is an article, not a user, so I think you’re testing the regular (MediaWiki core) watch feature rather than the feature this task is about (which lives in the CheckUser extension). Step to reproduce this:
Go to
Click on the user icon before a user name.
Open the three-dot menu.
Click
Add user page to watchlist
Remove user page from watchlist
Djackson-ctr
added a comment.
Jul 2 2025, 3:50 PM
2025-07-02 15:50:09 (UTC+0)
Comment Actions
@Tacsipacsi
Thank you for the information and the steps to reproduce...
I will retest this ticket.
kostajh
moved this task from
Inbox
to
Triaged
on the
CheckUser-UserInfoCard
board.
Jul 3 2025, 12:03 PM
2025-07-03 12:03:01 (UTC+0)
kostajh
edited projects, added
Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25))
; removed
Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4))
Jul 7 2025, 9:42 AM
2025-07-07 09:42:00 (UTC+0)
kostajh
moved this task from
Priority Backlog
to
Needs QA
on the
Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25))
board.
Djackson-ctr
moved this task from
Needs QA
to
Done
on the
Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25))
board.
Jul 8 2025, 4:02 AM
2025-07-08 04:02:20 (UTC+0)
Comment Actions
The new code has been implemented and is functioning as expected (WatchList message for adding/removing will display as:
User:{Username} and its discussion page
QA was completed for this ticket using Test wiki 1.45.0-wmf.8 (
103cda9
), thanks again
@Tacsipacsi
kostajh
closed this task as
Resolved
Jul 8 2025, 10:21 AM
2025-07-08 10:21:29 (UTC+0)
OKryva-WMF
added a project:
OKR-Work
Oct 3 2025, 3:44 PM
2025-10-03 15:44:12 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.
Wikimedia Foundation
Code of Conduct
Disclaimer
CC-BY-SA
GPL
Credits